[coreboot-gerrit] Change in coreboot[master]: ec/google/chromeec: Initialize SMI mask in google_chromeec_events_init

Furquan Shaikh (Code Review) gerrit at coreboot.org
Wed May 30 21:05:02 CEST 2018


Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/26709


Change subject: ec/google/chromeec: Initialize SMI mask in google_chromeec_events_init
......................................................................

ec/google/chromeec: Initialize SMI mask in google_chromeec_events_init

This change adds smi_events to google_chromeec_event_info and allows
mainboards to set SMI mask if current boot type is not S3 wakeup.

Change-Id: I899a6af6e57d295b4eac2039c8245ebcc73a42bb
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/ec/google/chromeec/ec.c
M src/ec/google/chromeec/ec.h
2 files changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/26709/1

diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c
index 72ca240..094f7ce 100644
--- a/src/ec/google/chromeec/ec.c
+++ b/src/ec/google/chromeec/ec.c
@@ -474,14 +474,16 @@
 		google_chromeec_set_sci_mask(info->sci_events);
 
 	} else {
+		google_chromeec_set_smi_mask(info->smi_events);
+
 		google_chromeec_log_events(info->log_events |
 						info->s5_wake_events);
+
 		if (google_chromeec_is_uhepi_supported())
 			google_chromeec_set_lazy_wake_masks
 					(info->s5_wake_events,
 					info->s3_wake_events,
 					info->s0ix_wake_events);
-
 	}
 
 	/* Clear wake event mask. */
diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h
index 24c8922..7310ade 100644
--- a/src/ec/google/chromeec/ec.h
+++ b/src/ec/google/chromeec/ec.h
@@ -152,6 +152,7 @@
 struct google_chromeec_event_info {
 	uint64_t log_events;
 	uint64_t sci_events;
+	uint64_t smi_events;
 	uint64_t s3_wake_events;
 	uint64_t s3_device_events;
 	uint64_t s5_wake_events;

-- 
To view, visit https://review.coreboot.org/26709
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I899a6af6e57d295b4eac2039c8245ebcc73a42bb
Gerrit-Change-Number: 26709
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180530/fdc4a585/attachment-0001.html>


More information about the coreboot-gerrit mailing list