[coreboot-gerrit] Change in coreboot[master]: util/docker/docs.coreboot.org: Patch recommonmark

Patrick Georgi (Code Review) gerrit at coreboot.org
Wed May 30 18:16:17 CEST 2018


Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/26699


Change subject: util/docker/docs.coreboot.org: Patch recommonmark
......................................................................

util/docker/docs.coreboot.org: Patch recommonmark

Using properties of a None object is a bad idea.

Change-Id: I287deab9168ab6124b05d0c6d6e8cdbd7fdc2eec
Signed-off-by: Patrick Georgi <patrick at georgi.software>
---
M util/docker/docs.coreboot.org/Dockerfile
A util/docker/docs.coreboot.org/fix-recommonmark.patch
2 files changed, 15 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/26699/1

diff --git a/util/docker/docs.coreboot.org/Dockerfile b/util/docker/docs.coreboot.org/Dockerfile
index fa2313c..6bf40e6 100644
--- a/util/docker/docs.coreboot.org/Dockerfile
+++ b/util/docker/docs.coreboot.org/Dockerfile
@@ -1,5 +1,7 @@
 FROM debian:sid
-RUN apt-get update && apt-get install -y make python-sphinx python-recommonmark python-sphinx-rtd-theme
+RUN apt-get update && apt-get install -y make python-sphinx python-recommonmark python-sphinx-rtd-theme patch && apt-get clean
+ADD fix-recommonmark.patch /tmp
+RUN cd /; patch -p0 -i /tmp/fix-recommonmark.patch
 USER nobody
 VOLUME /data-in /data-out
 ENTRYPOINT bash -c "cd /data-in/Documentation && make sphinx BUILDDIR=/tmp/build && rm -rf /data-out/* && mv /tmp/build/html/* /data-out/"
diff --git a/util/docker/docs.coreboot.org/fix-recommonmark.patch b/util/docker/docs.coreboot.org/fix-recommonmark.patch
new file mode 100644
index 0000000..218ef62
--- /dev/null
+++ b/util/docker/docs.coreboot.org/fix-recommonmark.patch
@@ -0,0 +1,12 @@
+--- /usr/lib/python2.7/dist-packages/recommonmark/parser.py.orig	2018-05-30 15:04:29.410187358 +0000
++++ /usr/lib/python2.7/dist-packages/recommonmark/parser.py	2018-05-30 15:04:34.934307335 +0000
+@@ -107,7 +107,8 @@
+         new_section.append(title_node)
+         name = nodes.fully_normalize_name(title_node.astext())
+         new_section['names'].append(name)
+-        self.current_node.document.note_implicit_target(new_section, new_section)
++        if self.current_node.document <> None:
++            self.current_node.document.note_implicit_target(new_section, new_section)
+         new_section['ids'].append(nodes.make_id(name))
+ 
+         self.section_handler.add_new_section(new_section, block.level)

-- 
To view, visit https://review.coreboot.org/26699
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I287deab9168ab6124b05d0c6d6e8cdbd7fdc2eec
Gerrit-Change-Number: 26699
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180530/db2a2d3b/attachment-0001.html>


More information about the coreboot-gerrit mailing list