[coreboot-gerrit] Change in coreboot[master]: checkpatch: exclude util/crossgcc/patches

Patrick Georgi (Code Review) gerrit at coreboot.org
Wed May 30 15:55:06 CEST 2018


Hello Martin Roth,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/26695

to review the following change.


Change subject: checkpatch: exclude util/crossgcc/patches
......................................................................

checkpatch: exclude util/crossgcc/patches

These files are supposed to contain trailing whitespace due to the patch
format.

Change-Id: I8816c05ea703964a332915a0675096836957b242
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
---
M util/gitconfig/pre-commit
M util/lint/lint-007-checkpatch
2 files changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/26695/1

diff --git a/util/gitconfig/pre-commit b/util/gitconfig/pre-commit
index 2aed957..e48d2e1 100755
--- a/util/gitconfig/pre-commit
+++ b/util/gitconfig/pre-commit
@@ -24,5 +24,6 @@
 if printf "%s\n" "$PATCHDIFF" | grep -q "@@"; then
 	echo
 	echo "Running checkpatch"
-	printf "%s\n" "$PATCHDIFF" | util/lint/checkpatch.pl --no-signoff -q -
+	printf "%s\n" "$PATCHDIFF" | util/lint/checkpatch.pl --no-signoff \
+		-q - --exclude=util/crossgcc/patches
 fi
diff --git a/util/lint/lint-007-checkpatch b/util/lint/lint-007-checkpatch
index 2e451cb..8c3b05a 100755
--- a/util/lint/lint-007-checkpatch
+++ b/util/lint/lint-007-checkpatch
@@ -21,6 +21,7 @@
 
 EXCLUDED_DIRS="^payloads/libpayload/util/kconfig\|\
 ^payloads/libpayload/curses/PDCurses\|\
+^util/crossgcc/patches\|\
 ^util/kconfig\|\
 ^src/vendorcode\|\
 ^Documentation"

-- 
To view, visit https://review.coreboot.org/26695
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8816c05ea703964a332915a0675096836957b242
Gerrit-Change-Number: 26695
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180530/f41536d1/attachment.html>


More information about the coreboot-gerrit mailing list