[coreboot-gerrit] Change in coreboot[master]: soc/cavium: Add secondary CPU support

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25752 )

Change subject: soc/cavium: Add secondary CPU support
......................................................................


Patch Set 16:

(6 comments)

https://review.coreboot.org/#/c/25752/16/src/mainboard/cavium/cn8100_sff_evb/mainboard.c
File src/mainboard/cavium/cn8100_sff_evb/mainboard.c:

https://review.coreboot.org/#/c/25752/16/src/mainboard/cavium/cn8100_sff_evb/mainboard.c@71
PS16, Line 71: 	printk(BIOS_INFO, "MB: #CPU cores      : %zu\n", cpu_get_num_available_cores());
line over 80 characters


https://review.coreboot.org/#/c/25752/16/src/soc/cavium/cn81xx/cpu.c
File src/soc/cavium/cn81xx/cpu.c:

https://review.coreboot.org/#/c/25752/16/src/soc/cavium/cn81xx/cpu.c@35
PS16, Line 35: static void (* secondary_c_entry)(size_t core_id) = NULL;
Unnecessary space before function pointer name


https://review.coreboot.org/#/c/25752/16/src/soc/cavium/cn81xx/cpu.c@35
PS16, Line 35: static void (* secondary_c_entry)(size_t core_id) = NULL;
space prohibited after that '*' (ctx:BxW)


https://review.coreboot.org/#/c/25752/16/src/soc/cavium/cn81xx/cpu.c@67
PS16, Line 67: size_t start_cpu(size_t cpu, void (* entry_64)(size_t core_id))
space prohibited after that '*' (ctx:BxW)


https://review.coreboot.org/#/c/25752/16/src/soc/cavium/cn81xx/cpu.c@121
PS16, Line 121: 	while (!stopwatch_expired(&sw) && !read64(&secondary_booted));
trailing statements should be on next line


https://review.coreboot.org/#/c/25752/16/src/soc/cavium/cn81xx/include/soc/cpu.h
File src/soc/cavium/cn81xx/include/soc/cpu.h:

https://review.coreboot.org/#/c/25752/16/src/soc/cavium/cn81xx/include/soc/cpu.h@47
PS16, Line 47: size_t start_cpu(size_t cpu, void (* entry_64)(size_t core_id));
space prohibited after that '*' (ctx:BxW)



-- 
To view, visit https://review.coreboot.org/25752
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07428161615bcd3d03a3eea0df2dd813e08c8f66
Gerrit-Change-Number: 25752
Gerrit-PatchSet: 16
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 30 May 2018 13:51:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180530/a49c4071/attachment.html>