[coreboot-gerrit] Change in coreboot[master]: device/oprom/x86emu/prim_ops.c: Fix coding style
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Wed May 30 13:42:33 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26353 )
Change subject: device/oprom/x86emu/prim_ops.c: Fix coding style
......................................................................
Patch Set 10:
(65 comments)
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c
File src/device/oprom/x86emu/prim_ops.c:
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@195
PS10, Line 195: if (set_carry) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@207
PS10, Line 207: if (set_carry) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@297
PS10, Line 297: if (ACCESS_FLAG(F_CF)) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@316
PS10, Line 316: if (ACCESS_FLAG(F_CF)) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@765
PS10, Line 765: if ((cnt = s % 9) != 0) {
do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@812
PS10, Line 812: if ((cnt = s % 17) != 0) {
do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@817
PS10, Line 817: if (ACCESS_FLAG(F_CF)) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@836
PS10, Line 836: if ((cnt = s % 33) != 0) {
do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@883
PS10, Line 883: if ((cnt = s % 9) != 0) {
do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@888
PS10, Line 888: /* note hackery here. Access_flag(..) evaluates to either
line over 80 characters
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@947
PS10, Line 947: if ((cnt = s % 17) != 0) {
do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@956
PS10, Line 956: if (ACCESS_FLAG(F_CF)) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@979
PS10, Line 979: if ((cnt = s % 33) != 0) {
do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@988
PS10, Line 988: if (cnt != 1) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1028
PS10, Line 1028: if ((cnt = s % 8) != 0) {
do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1061
PS10, Line 1061: if ((cnt = s % 16) != 0) {
do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1086
PS10, Line 1086: if ((cnt = s % 32) != 0) {
do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1126
PS10, Line 1126: if ((cnt = s % 8) != 0) { /* not a typo, do nada if cnt==0 */
do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1157
PS10, Line 1157: if ((cnt = s % 16) != 0) {
do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1180
PS10, Line 1180: if ((cnt = s % 32) != 0) {
do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1290
PS10, Line 1290: CONDITIONAL_SET_FLAG((((res & 0x80000000) == 0x80000000) ^
line over 80 characters
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1325
PS10, Line 1325: if (cnt == 1) {
braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1360
PS10, Line 1360: if (cnt == 1) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1362
PS10, Line 1362: } else {
space required after that close brace '}'
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1362
PS10, Line 1362: } else {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1394
PS10, Line 1394: if (cnt == 1) {
braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1426
PS10, Line 1426: if (sf) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1464
PS10, Line 1464: if (sf) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1502
PS10, Line 1502: if (sf) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1578
PS10, Line 1578: CONDITIONAL_SET_FLAG((((res & 0x80000000) == 0x80000000) ^
line over 80 characters
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1613
PS10, Line 1613: if (cnt == 1) {
braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1647
PS10, Line 1647: if (cnt == 1) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1649
PS10, Line 1649: } else {
space required after that close brace '}'
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1649
PS10, Line 1649: } else {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1672
PS10, Line 1672: if (ACCESS_FLAG(F_CF)) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1674
PS10, Line 1674: } else {
space required after that close brace '}'
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1674
PS10, Line 1674: } else {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1696
PS10, Line 1696: if (ACCESS_FLAG(F_CF)) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1698
PS10, Line 1698: } else {
space required after that close brace '}'
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1698
PS10, Line 1698: } else {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1720
PS10, Line 1720: if (ACCESS_FLAG(F_CF)) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1722
PS10, Line 1722: } else {
space required after that close brace '}'
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1722
PS10, Line 1722: } else {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1938
PS10, Line 1938: if ((d_sign = d & 0x80000000) != 0) {
do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1938
PS10, Line 1938: if ((d_sign = d & 0x80000000) != 0) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1943
PS10, Line 1943: if ((s_sign = s & 0x80000000) != 0) {
do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@1943
PS10, Line 1943: if ((s_sign = s & 0x80000000) != 0) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@2308
PS10, Line 2308: } else if (size == 2) {
code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@2308
PS10, Line 2308: } else if (size == 2) {
please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@2308
PS10, Line 2308: } else if (size == 2) {
space required after that close brace '}'
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@2311
PS10, Line 2311: } else {
code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@2311
PS10, Line 2311: } else {
please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@2311
PS10, Line 2311: } else {
space required after that close brace '}'
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@2321
PS10, Line 2321: if (ACCESS_FLAG(F_DF)) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@2356
PS10, Line 2356: } else {
code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@2356
PS10, Line 2356: } else {
please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@2356
PS10, Line 2356: } else {
space required after that close brace '}'
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@2366
PS10, Line 2366: if (ACCESS_FLAG(F_DF)) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@2379
PS10, Line 2379: if (M.x86.mode & SYSMODE_32BIT_REP) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@2475
PS10, Line 2475: /* Regardless if we have real data from the hardware, the emulator
line over 80 characters
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@2476
PS10, Line 2476: * will only support upto feature 1, which we set in register EAX.
line over 80 characters
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@2486
PS10, Line 2486: /* If we don't have x86 compatible hardware, we return values from an
line over 80 characters
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@2487
PS10, Line 2487: * Intel 486dx4; which was one of the first processors to have CPUID.
line over 80 characters
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@2493
PS10, Line 2493: /* In the case that we have hardware CPUID instruction, we make sure
line over 80 characters
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@2500
PS10, Line 2500: * return all zeros when queried for invalid or unsupported feature
line over 80 characters
--
To view, visit https://review.coreboot.org/26353
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I010f3e02813d38293a7ab7fc84f60b8c2ec098a7
Gerrit-Change-Number: 26353
Gerrit-PatchSet: 10
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Comment-Date: Wed, 30 May 2018 11:42:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180530/fef287ac/attachment.html>
More information about the coreboot-gerrit
mailing list