[coreboot-gerrit] Change in coreboot[master]: src/console: Fix coding style

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26303 )

Change subject: src/console: Fix coding style
......................................................................


Patch Set 2:

(13 comments)

https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c
File src/console/vtxprintf.c:

https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@99
PS2, Line 99: 	if (num == 0) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@101
PS2, Line 101:         } else {
code indent should use tabs where possible


https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@101
PS2, Line 101:         } else {
please, no spaces at the start of a line


https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@101
PS2, Line 101:         } else {
space required after that close brace '}'


https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@107
PS2, Line 107: 	if (i > precision) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@179
PS2, Line 179:                 } else if (*fmt == '*') {
code indent should use tabs where possible


https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@179
PS2, Line 179:                 } else if (*fmt == '*') {
please, no spaces at the start of a line


https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@179
PS2, Line 179:                 } else if (*fmt == '*') {
space required after that close brace '}'


https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@193
PS2, Line 193: 			if (is_digit(*fmt)) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@195
PS2, Line 195:                         } else if (*fmt == '*') {
code indent should use tabs where possible


https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@195
PS2, Line 195:                         } else if (*fmt == '*') {
please, no spaces at the start of a line


https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@195
PS2, Line 195:                         } else if (*fmt == '*') {
space required after that close brace '}'


https://review.coreboot.org/#/c/26303/2/src/console/vtxprintf.c@200
PS2, Line 200: 			if (precision < 0) {
braces {} are not necessary for single statement blocks



-- 
To view, visit https://review.coreboot.org/26303
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57724262ade87e7907d31ea66e4f1b9c382ef3db
Gerrit-Change-Number: 26303
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Comment-Date: Wed, 30 May 2018 11:13:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180530/308c5afc/attachment.html>