[coreboot-gerrit] Change in coreboot[master]: cpu/x86/mtrr: Get rid of CACHE_ROM_SIZE_OVERRIDE

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Wed May 30 12:52:57 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26566 )

Change subject: cpu/x86/mtrr: Get rid of CACHE_ROM_SIZE_OVERRIDE
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/26566/5/src/include/cpu/x86/mtrr.h
File src/include/cpu/x86/mtrr.h:

https://review.coreboot.org/#/c/26566/5/src/include/cpu/x86/mtrr.h@146
PS5, Line 146:     (OPTIMAL_CACHE_ROM_SIZE >= (2 * CONFIG_ROM_SIZE))
please, no spaces at the start of a line



-- 
To view, visit https://review.coreboot.org/26566
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d0096f14a9d343c2e646e48175fe2127198a822
Gerrit-Change-Number: 26566
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: David Hendricks <david.hendricks at gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 30 May 2018 10:52:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180530/f95162dd/attachment.html>


More information about the coreboot-gerrit mailing list