[coreboot-gerrit] Change in coreboot[master]: src: Use "foo *bar" instead of "foo* bar"

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26461 )

Change subject: src: Use "foo *bar" instead of "foo* bar"
......................................................................


Patch Set 3:

(23 comments)

https://review.coreboot.org/#/c/26461/3/src/drivers/amd/agesa/eventlog.c
File src/drivers/amd/agesa/eventlog.c:

https://review.coreboot.org/#/c/26461/3/src/drivers/amd/agesa/eventlog.c@89
PS3, Line 89: 	const char *statusStrings[] = { "AGESA_SUCCESS", "AGESA_UNSUPPORTED",
char * array declaration might be better as static const


https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h
File src/northbridge/amd/amdht/h3finit.h:

https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@229
PS3, Line 229: 	 *	@param[in,out] u8 *LinkWidthIn  = modify to change the Link Witdh In
line over 80 characters


https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@230
PS3, Line 230: 	 *	@param[in,out] u8 *LinkWidthOut  = modify to change the Link Witdh Out
line over 80 characters


https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@231
PS3, Line 231: 	 *	@param[in,out] u32 *FreqCap = modify to change the link's frequency capability
line over 80 characters


https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@232
PS3, Line 232: 	 *	@param[in,out] u32 *FeatureCap = modify to change the link's feature capability
line over 80 characters


https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@269
PS3, Line 269: 	 *	@param[in,out]  u8 *ABLinkWidthLimit = modify to change the Link Witdh In
line over 80 characters


https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@270
PS3, Line 270: 	 *	@param[in,out]  u8 *BALinkWidthLimit = modify to change the Link Witdh Out
line over 80 characters


https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@271
PS3, Line 271: 	 *	@param[in,out]  u32 *PCBFreqCap  = modify to change the link's frequency capability
line over 80 characters


https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@302
PS3, Line 302: 	 *	@param[in,out]  u8 *DownstreamLinkWidthLimit = modify to change the Link Witdh In
line over 80 characters


https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@303
PS3, Line 303: 	 *	@param[in,out]  u8 *UpstreamLinkWidthLimit  = modify to change the Link Witdh Out
line over 80 characters


https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@304
PS3, Line 304: 	 *	@param[in,out]  u32 *PCBFreqCap = modify to change the link's frequency capability
line over 80 characters


https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@403
PS3, Line 403: 	 *	@param[in,out]  u8 *LinkWidthIn    = modify to change the Link Witdh In
line over 80 characters


https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@404
PS3, Line 404: 	 *	@param[in,out]  u8 *LinkWidthOut   = modify to change the Link Witdh Out
line over 80 characters


https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@405
PS3, Line 405: 	 *	@param[in,out]  u16 *LinkFrequency = modify to change the link's frequency capability
line over 80 characters


https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@434
PS3, Line 434: 	 *	@param[in,out]  u8 *LinkWidthIn = modify to change the Link Witdh In
line over 80 characters


https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@435
PS3, Line 435: 	 *	@param[in,out]  u8 *LinkWidthOut = modify to change the Link Witdh Out
line over 80 characters


https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@436
PS3, Line 436: 	 *	@param[in,out]  u16 *LinkFrequency  = modify to change the link's frequency capability
line over 80 characters


https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@462
PS3, Line 462: 	 *	@param[in]  u8 *pEventData0 = useful data associated with the event.
line over 80 characters


https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/pi/agesawrapper_call.h
File src/northbridge/amd/pi/agesawrapper_call.h:

https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/pi/agesawrapper_call.h@35
PS3, Line 35: 	const char *statusStrings[] = { "AGESA_SUCCESS", "AGESA_UNSUPPORTED",
char * array declaration might be better as static const


https://review.coreboot.org/#/c/26461/3/src/northbridge/intel/fsp_sandybridge/raminit.c
File src/northbridge/intel/fsp_sandybridge/raminit.c:

https://review.coreboot.org/#/c/26461/3/src/northbridge/intel/fsp_sandybridge/raminit.c@24
PS3, Line 24: static const char *ecc_decoder[] = {
static const char * array should probably be static const char * const


https://review.coreboot.org/#/c/26461/3/src/northbridge/intel/haswell/raminit.c
File src/northbridge/intel/haswell/raminit.c:

https://review.coreboot.org/#/c/26461/3/src/northbridge/intel/haswell/raminit.c@65
PS3, Line 65: static const char *ecc_decoder[] = {
static const char * array should probably be static const char * const


https://review.coreboot.org/#/c/26461/3/src/northbridge/intel/sandybridge/raminit_mrc.c
File src/northbridge/intel/sandybridge/raminit_mrc.c:

https://review.coreboot.org/#/c/26461/3/src/northbridge/intel/sandybridge/raminit_mrc.c@133
PS3, Line 133: static const char *ecc_decoder[] = {
static const char * array should probably be static const char * const


https://review.coreboot.org/#/c/26461/3/src/southbridge/amd/sb700/sm.c
File src/southbridge/amd/sb700/sm.c:

https://review.coreboot.org/#/c/26461/3/src/southbridge/amd/sb700/sm.c@51
PS3, Line 51: static const char *power_mode_names[] = {
static const char * array should probably be static const char * const



-- 
To view, visit https://review.coreboot.org/26461
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2bb6cc80ac2bdc389c60c7ffac4bba937f0fca8
Gerrit-Change-Number: 26461
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 30 May 2018 07:36:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180530/0ba6cf8c/attachment.html>