[coreboot-gerrit] Change in coreboot[master]: mainboard/asrock/e350m1: Fix coding style
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Tue May 29 21:42:37 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26470 )
Change subject: mainboard/asrock/e350m1: Fix coding style
......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/#/c/26470/2/src/mainboard/asrock/e350m1/BiosCallOuts.c
File src/mainboard/asrock/e350m1/BiosCallOuts.c:
https://review.coreboot.org/#/c/26470/2/src/mainboard/asrock/e350m1/BiosCallOuts.c@23
PS2, Line 23: VOID *ConfigPtr);
need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/#/c/26470/2/src/mainboard/asrock/e350m1/BiosCallOuts.c@91
PS2, Line 91: /* this seems to be just copy-pasted from the AMD reference boards and needs
line over 80 characters
https://review.coreboot.org/#/c/26470/2/src/mainboard/asrock/e350m1/OemCustomize.c
File src/mainboard/asrock/e350m1/OemCustomize.c:
https://review.coreboot.org/#/c/26470/2/src/mainboard/asrock/e350m1/OemCustomize.c@37
PS2, Line 37: }
Statements should start on a tabstop
https://review.coreboot.org/#/c/26470/2/src/mainboard/asrock/e350m1/OemCustomize.c@52
PS2, Line 52: }
Statements should start on a tabstop
https://review.coreboot.org/#/c/26470/2/src/mainboard/asrock/e350m1/mptable.c
File src/mainboard/asrock/e350m1/mptable.c:
https://review.coreboot.org/#/c/26470/2/src/mainboard/asrock/e350m1/mptable.c@27
PS2, Line 27: [0x00] = 0x10, 0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, /* INTA# - INTH# */
line over 80 characters
https://review.coreboot.org/#/c/26470/2/src/mainboard/asrock/e350m1/mptable.c@28
PS2, Line 28: [0x08] = 0x00, 0x00, 0x00, 0x00, 0x1F, 0x1F, 0x1F, 0x1F, /* Misc-nil,0,1,2, INT from Serial irq */
line over 80 characters
--
To view, visit https://review.coreboot.org/26470
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a6d5635dc10e486fa137cfec08842f634f34e66
Gerrit-Change-Number: 26470
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 29 May 2018 19:42:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180529/0ee5d603/attachment.html>
More information about the coreboot-gerrit
mailing list