[coreboot-gerrit] Change in coreboot[master]: sb/intel/common/spi.c: Add a SPI write protect function

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Tue May 29 18:53:18 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23146 )

Change subject: sb/intel/common/spi.c: Add a SPI write protect function
......................................................................


Patch Set 13:

(4 comments)

https://review.coreboot.org/#/c/23146/13/src/southbridge/intel/common/spi.c
File src/southbridge/intel/common/spi.c:

https://review.coreboot.org/#/c/23146/13/src/southbridge/intel/common/spi.c@978
PS13, Line 978: 	(((((limit) >> SPI_FPR_SHIFT) & ICH7_SPI_FPR_MASK) << ICH7_SPI_FPR_LIMIT_SHIFT) |\
line over 80 characters


https://review.coreboot.org/#/c/23146/13/src/southbridge/intel/common/spi.c@979
PS13, Line 979: 	 ((((base) >> SPI_FPR_SHIFT) & ICH7_SPI_FPR_MASK) << SPI_FPR_BASE_SHIFT))
line over 80 characters


https://review.coreboot.org/#/c/23146/13/src/southbridge/intel/common/spi.c@981
PS13, Line 981: 	(((((limit) >> SPI_FPR_SHIFT) & ICH9_SPI_FPR_MASK) << ICH9_SPI_FPR_LIMIT_SHIFT) |\
line over 80 characters


https://review.coreboot.org/#/c/23146/13/src/southbridge/intel/common/spi.c@982
PS13, Line 982: 	 ((((base) >> SPI_FPR_SHIFT) & ICH9_SPI_FPR_MASK) << SPI_FPR_BASE_SHIFT))
line over 80 characters



-- 
To view, visit https://review.coreboot.org/23146
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0a9a0de639c5d6761a77a56ceba6d89110a4ea1
Gerrit-Change-Number: 23146
Gerrit-PatchSet: 13
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 29 May 2018 16:53:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180529/3d105ba2/attachment.html>


More information about the coreboot-gerrit mailing list