[coreboot-gerrit] Change in coreboot[master]: cbfstool: add an option for creating a topswap bootblock

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Tue May 29 13:43:55 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22537 )

Change subject: cbfstool: add an option for creating a topswap bootblock
......................................................................


Patch Set 7:

(2 comments)

https://review.coreboot.org/#/c/22537/7/util/cbfstool/cbfstool.c
File util/cbfstool/cbfstool.c:

https://review.coreboot.org/#/c/22537/7/util/cbfstool/cbfstool.c@1643
PS7, Line 1643: 				switch (param.topswap_size){
switch and case should be at the same indent


https://review.coreboot.org/#/c/22537/7/util/cbfstool/cbfstool.c@1643
PS7, Line 1643: 				switch (param.topswap_size){
space required before the open brace '{'



-- 
To view, visit https://review.coreboot.org/22537
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e455dc8b7f54e55f2229491695cf4218d9cfef8
Gerrit-Change-Number: 22537
Gerrit-PatchSet: 7
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-Comment-Date: Tue, 29 May 2018 11:43:55 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180529/767645f6/attachment.html>


More information about the coreboot-gerrit mailing list