[coreboot-gerrit] Change in coreboot[master]: cbfstool: add an option for creating a topswap bootblock

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22537 )

Change subject: cbfstool: add an option for creating a topswap bootblock
......................................................................


Patch Set 5:

(14 comments)

https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c
File util/cbfstool/cbfstool.c:

https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@344
PS5, Line 344: static int add_second_bootblock(struct buffer *buffer,uint32_t *offset)
space required after that ',' (ctx:VxV)


https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@347
PS5, Line 347: 	char* new_data = (char*)malloc(bb_size);
"(foo*)" should be "(foo *)"


https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@347
PS5, Line 347: 	char* new_data = (char*)malloc(bb_size);
"foo* bar" should be "foo *bar"


https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@349
PS5, Line 349: 	if (new_data == NULL){
space required before the open brace '{'


https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@353
PS5, Line 353: 	char* bb1_offset = new_data +
"foo* bar" should be "foo *bar"


https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@355
PS5, Line 355: 	char* bb2_offset = new_data + (bb_size - buffer->size);
"foo* bar" should be "foo *bar"


https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@356
PS5, Line 356: 	DEBUG ("bb1 offset = 0x%p, bb2 offset = 0x%p\n",
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@410
PS5, Line 410: 	 * topswap_size*2 bytes for bootblock to accomodate the second
'accomodate' may be misspelled - perhaps 'accommodate'?


https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@414
PS5, Line 414: 		if(add_second_bootblock(&buffer, &offset)){
space required before the open brace '{'


https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@414
PS5, Line 414: 		if(add_second_bootblock(&buffer, &offset)){
space required before the open parenthesis '('


https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@1341
PS5, Line 1341:              "        [-j topswap-size (in hex)]                            "
code indent should use tabs where possible


https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@1341
PS5, Line 1341:              "        [-j topswap-size (in hex)]                            "
please, no spaces at the start of a line


https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@1643
PS5, Line 1643: 				switch (param.topswap_size){
switch and case should be at the same indent


https://review.coreboot.org/#/c/22537/5/util/cbfstool/cbfstool.c@1643
PS5, Line 1643: 				switch (param.topswap_size){
space required before the open brace '{'



-- 
To view, visit https://review.coreboot.org/22537
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e455dc8b7f54e55f2229491695cf4218d9cfef8
Gerrit-Change-Number: 22537
Gerrit-PatchSet: 5
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-Comment-Date: Tue, 29 May 2018 11:05:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180529/cd0075b7/attachment.html>