[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Enable RT5682 headset codec for BIP board

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon May 28 16:26:29 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26211 )

Change subject: mb/google/octopus: Enable RT5682 headset codec for BIP board
......................................................................


Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/26211/7/src/mainboard/google/octopus/variants/bip/gpio.c
File src/mainboard/google/octopus/variants/bip/gpio.c:

https://review.coreboot.org/#/c/26211/7/src/mainboard/google/octopus/variants/bip/gpio.c@196
PS7, Line 196: 	PAD_CFG_GPI_APIC_IOS(GPIO_137, NONE, DEEP, EDGE_BOTH, INVERT, HIZCRx1, DISPUPD),/* GPIO_137 -- HP_INT_ODL */
line over 80 characters



-- 
To view, visit https://review.coreboot.org/26211
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee91518c03a0e9e6ed52bc54a60fc607730a0b7d
Gerrit-Change-Number: 26211
Gerrit-PatchSet: 7
Gerrit-Owner: Naveen Manohar <naveen.m at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: John Zhao <john.zhao at intel.com>
Gerrit-Reviewer: Naveen Manohar <naveen.m at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 28 May 2018 14:26:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180528/6f3629c7/attachment.html>


More information about the coreboot-gerrit mailing list