[coreboot-gerrit] Change in libgfxinit[master]: gma: Fix Ironlake panel fitting

Nico Huber (Code Review) gerrit at coreboot.org
Mon May 28 15:41:00 CEST 2018


Nico Huber has uploaded this change for review. ( https://review.coreboot.org/26647


Change subject: gma: Fix Ironlake panel fitting
......................................................................

gma: Fix Ironlake panel fitting

Apparently the scaled width must be even. This seems to be nowhere
documented.

Change-Id: Ic1484eda0f6022cd8a37611fdfb9d2c50b390b72
Signed-off-by: Nico Huber <nico.h at gmx.de>
---
M common/hw-gfx-gma-pipe_setup.adb
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/47/26647/1

diff --git a/common/hw-gfx-gma-pipe_setup.adb b/common/hw-gfx-gma-pipe_setup.adb
index 4544e73..765d29a 100644
--- a/common/hw-gfx-gma-pipe_setup.adb
+++ b/common/hw-gfx-gma-pipe_setup.adb
@@ -413,6 +413,11 @@
          Max_Height  => Pos32 (Mode.V_Visible),
          Framebuffer => Framebuffer);
 
+      -- Apparently not documented, but needs to be even:
+      if Width mod 2 = 1 then
+         Width := Width + 1;
+      end if;
+
       Registers.Write
         (Register => Controller.PF_CTRL,
          Value    => PF_CTRL_ENABLE or PF_Ctrl_Pipe_Sel or PF_CTRL_FILTER_MED);

-- 
To view, visit https://review.coreboot.org/26647
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1484eda0f6022cd8a37611fdfb9d2c50b390b72
Gerrit-Change-Number: 26647
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180528/61c415ce/attachment.html>


More information about the coreboot-gerrit mailing list