[coreboot-gerrit] Change in coreboot[master]: soc/intel/broadwell: decouple PEI memory struct from coreboot header

Matt DeVillier (Code Review) gerrit at coreboot.org
Mon May 28 05:28:06 CEST 2018


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/26598

to look at the new patch set (#2).

Change subject: soc/intel/broadwell: decouple PEI memory struct from coreboot header
......................................................................

soc/intel/broadwell: decouple PEI memory struct from coreboot header

Recent changes to field lengths in include/memory_info.h resulted in
a mismatch between the memory_info struct the MRC blob writes to and
the struct used by coreboot to parse out data for the SMBIOS tables.
This mismatch caused type 17 SMBIOS tables to be filled incorrectly.

The solution used here is to define the memory_info struct as expected
by MRC in the pei_data header, and manually copy the data field by field
into the coreboot memory_info struct, observing the more restrictive
lengths for the two structs.

Test: build/boot google/lulu, verify SMBIOS type 17 tables correctly
populated.

Change-Id: I932b7b41ae1e3fd364d056a8c91f7ed5d25dbafc
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/soc/intel/broadwell/include/soc/pei_data.h
M src/soc/intel/broadwell/romstage/raminit.c
2 files changed, 120 insertions(+), 3 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/26598/2
-- 
To view, visit https://review.coreboot.org/26598
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I932b7b41ae1e3fd364d056a8c91f7ed5d25dbafc
Gerrit-Change-Number: 26598
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180528/da1bb91c/attachment.html>


More information about the coreboot-gerrit mailing list