[coreboot-gerrit] Change in coreboot[master]: soc/intel/fsp_broadwell_de: Get rid of device_t

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26589 )

Change subject: soc/intel/fsp_broadwell_de: Get rid of device_t
......................................................................


Patch Set 1:

(5 comments)

https://review.coreboot.org/#/c/26589/1/src/soc/intel/fsp_broadwell_de/chip.c
File src/soc/intel/fsp_broadwell_de/chip.c:

https://review.coreboot.org/#/c/26589/1/src/soc/intel/fsp_broadwell_de/chip.c@92
PS1, Line 92: static void pci_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
line over 80 characters


https://review.coreboot.org/#/c/26589/1/src/soc/intel/fsp_broadwell_de/chip.c@92
PS1, Line 92: static void pci_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26589/1/src/soc/intel/fsp_broadwell_de/chip.c@92
PS1, Line 92: static void pci_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26589/1/src/soc/intel/fsp_broadwell_de/smmrelocate.c
File src/soc/intel/fsp_broadwell_de/smmrelocate.c:

https://review.coreboot.org/#/c/26589/1/src/soc/intel/fsp_broadwell_de/smmrelocate.c@158
PS1, Line 158: 			struct device *dev = PCI_DEV(QPI_BUS, SMM_DEV, SMM_FUNC);
line over 80 characters


https://review.coreboot.org/#/c/26589/1/src/soc/intel/fsp_broadwell_de/southcluster.c
File src/soc/intel/fsp_broadwell_de/southcluster.c:

https://review.coreboot.org/#/c/26589/1/src/soc/intel/fsp_broadwell_de/southcluster.c@42
PS1, Line 42: add_mmio_resource(struct device *dev, int i, unsigned long addr, unsigned long size)
line over 80 characters



-- 
To view, visit https://review.coreboot.org/26589
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68c455d4bc524c2dd2d3ba87ab6641e70c78521c
Gerrit-Change-Number: 26589
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 27 May 2018 16:01:55 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180527/238a819e/attachment.html>