[coreboot-gerrit] Change in coreboot[master]: soc/intel/fsp_baytrail: Get rid of device_t

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26588 )

Change subject: soc/intel/fsp_baytrail: Get rid of device_t
......................................................................


Patch Set 1:

(8 comments)

https://review.coreboot.org/#/c/26588/1/src/soc/intel/fsp_baytrail/chip.c
File src/soc/intel/fsp_baytrail/chip.c:

https://review.coreboot.org/#/c/26588/1/src/soc/intel/fsp_baytrail/chip.c@76
PS1, Line 76: static void pci_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
line over 80 characters


https://review.coreboot.org/#/c/26588/1/src/soc/intel/fsp_baytrail/chip.c@76
PS1, Line 76: static void pci_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26588/1/src/soc/intel/fsp_baytrail/chip.c@76
PS1, Line 76: static void pci_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26588/1/src/soc/intel/fsp_baytrail/gfx.c
File src/soc/intel/fsp_baytrail/gfx.c:

https://review.coreboot.org/#/c/26588/1/src/soc/intel/fsp_baytrail/gfx.c@77
PS1, Line 77: static inline void gfx_run_script(struct device *dev, const struct reg_script *ops)
line over 80 characters


https://review.coreboot.org/#/c/26588/1/src/soc/intel/fsp_baytrail/lpe.c
File src/soc/intel/fsp_baytrail/lpe.c:

https://review.coreboot.org/#/c/26588/1/src/soc/intel/fsp_baytrail/lpe.c@44
PS1, Line 44: static void assign_device_nvs(struct device *dev, u32 *field, unsigned index)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26588/1/src/soc/intel/fsp_baytrail/lpss.c
File src/soc/intel/fsp_baytrail/lpss.c:

https://review.coreboot.org/#/c/26588/1/src/soc/intel/fsp_baytrail/lpss.c@32
PS1, Line 32: static void dev_enable_acpi_mode(struct device *dev, int iosf_reg, int nvs_index)
line over 80 characters


https://review.coreboot.org/#/c/26588/1/src/soc/intel/fsp_baytrail/southcluster.c
File src/soc/intel/fsp_baytrail/southcluster.c:

https://review.coreboot.org/#/c/26588/1/src/soc/intel/fsp_baytrail/southcluster.c@53
PS1, Line 53: add_mmio_resource(struct device *dev, int i, unsigned long addr, unsigned long size)
line over 80 characters


https://review.coreboot.org/#/c/26588/1/src/soc/intel/fsp_baytrail/southcluster.c@327
PS1, Line 327: static void sc_add_io_resource(struct device *dev, int base, int size, int index)
line over 80 characters



-- 
To view, visit https://review.coreboot.org/26588
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52534b67cd3cd8489925941f45a756b3d430e072
Gerrit-Change-Number: 26588
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 27 May 2018 15:54:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180527/0a92f852/attachment.html>