[coreboot-gerrit] Change in coreboot[master]: soc/intel/broadwe: Get rid of device_t

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Sun May 27 16:43:10 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26583 )

Change subject: soc/intel/broadwe: Get rid of device_t
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/26583/1/src/soc/intel/broadwell/lpc.c
File src/soc/intel/broadwell/lpc.c:

https://review.coreboot.org/#/c/26583/1/src/soc/intel/broadwell/lpc.c@525
PS1, Line 525: static void pch_lpc_add_io_resource(struct device *dev, u16 base, u16 size, int index)
line over 80 characters


https://review.coreboot.org/#/c/26583/1/src/soc/intel/broadwell/lpc.c@538
PS1, Line 538: static void pch_lpc_add_gen_io_resources(struct device *dev, int reg_value, int index)
line over 80 characters


https://review.coreboot.org/#/c/26583/1/src/soc/intel/broadwell/systemagent.c
File src/soc/intel/broadwell/systemagent.c:

https://review.coreboot.org/#/c/26583/1/src/soc/intel/broadwell/systemagent.c@40
PS1, Line 40: static int get_pcie_bar(struct device *dev, unsigned int index, u32 *base, u32 *len)
line over 80 characters



-- 
To view, visit https://review.coreboot.org/26583
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I043f4169ad080f9a449c8780500332c9512b62ff
Gerrit-Change-Number: 26583
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 27 May 2018 14:43:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180527/397978f2/attachment.html>


More information about the coreboot-gerrit mailing list