[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Implement EFI_MP_SERVICES_PPI structure APIs

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25634 )

Change subject: soc/intel/common: Implement EFI_MP_SERVICES_PPI structure APIs
......................................................................


Patch Set 34:

(15 comments)

https://review.coreboot.org/#/c/25634/34/src/soc/intel/common/block/cpu/mp_service_ppi.c
File src/soc/intel/common/block/cpu/mp_service_ppi.c:

https://review.coreboot.org/#/c/25634/34/src/soc/intel/common/block/cpu/mp_service_ppi.c@40
PS34, Line 40: 	CONST EFI_PEI_SERVICES	**ignored1,
need consistent spacing around '*' (ctx:WxO)


https://review.coreboot.org/#/c/25634/34/src/soc/intel/common/block/cpu/mp_service_ppi.c@57
PS34, Line 57: 	CONST EFI_PEI_SERVICES		**ignored1,
need consistent spacing around '*' (ctx:WxO)


https://review.coreboot.org/#/c/25634/34/src/soc/intel/common/block/cpu/mp_service_ppi.c@60
PS34, Line 60: 	EFI_PROCESSOR_INFORMATION	*ProcessorInfoBuffer
need consistent spacing around '*' (ctx:WxV)


https://review.coreboot.org/#/c/25634/34/src/soc/intel/common/block/cpu/mp_service_ppi.c@85
PS34, Line 85: 	CONST EFI_PEI_SERVICES	**ignored1,
need consistent spacing around '*' (ctx:WxO)


https://review.coreboot.org/#/c/25634/34/src/soc/intel/common/block/cpu/mp_service_ppi.c@90
PS34, Line 90: 	VOID			*ProcedureArgument
need consistent spacing around '*' (ctx:WxV)


https://review.coreboot.org/#/c/25634/34/src/soc/intel/common/block/cpu/mp_service_ppi.c@101
PS34, Line 101: 		die("mp_startup_all_aps returns error!\n");
Prefer using '"%s...", __func__' to using 'mp_startup_all_aps', this function's name, in a string


https://review.coreboot.org/#/c/25634/34/src/soc/intel/common/block/cpu/mp_service_ppi.c@107
PS34, Line 107: 	CONST EFI_PEI_SERVICES	**ignored1,
need consistent spacing around '*' (ctx:WxO)


https://review.coreboot.org/#/c/25634/34/src/soc/intel/common/block/cpu/mp_service_ppi.c@112
PS34, Line 112: 	VOID			*ProcedureArgument
need consistent spacing around '*' (ctx:WxV)


https://review.coreboot.org/#/c/25634/34/src/soc/intel/common/block/cpu/mp_service_ppi.c@129
PS34, Line 129: 		die("mp_startup_this_ap returns error!\n");
Prefer using '"%s...", __func__' to using 'mp_startup_this_ap', this function's name, in a string


https://review.coreboot.org/#/c/25634/34/src/soc/intel/common/block/cpu/mp_service_ppi.c@135
PS34, Line 135: 	CONST EFI_PEI_SERVICES	**ignored1,
need consistent spacing around '*' (ctx:WxO)


https://review.coreboot.org/#/c/25634/34/src/soc/intel/common/block/cpu/mp_service_ppi.c@145
PS34, Line 145: static EFI_STATUS mp_enable_disable_ap (
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/25634/34/src/soc/intel/common/block/cpu/mp_service_ppi.c@146
PS34, Line 146: 	CONST EFI_PEI_SERVICES	**ignored1,
need consistent spacing around '*' (ctx:WxO)


https://review.coreboot.org/#/c/25634/34/src/soc/intel/common/block/cpu/mp_service_ppi.c@150
PS34, Line 150: 	UINT32			*HealthFlag
need consistent spacing around '*' (ctx:WxV)


https://review.coreboot.org/#/c/25634/34/src/soc/intel/common/block/cpu/mp_service_ppi.c@156
PS34, Line 156: static EFI_STATUS mp_identify_processor (
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/25634/34/src/soc/intel/common/block/cpu/mp_service_ppi.c@157
PS34, Line 157: 	CONST EFI_PEI_SERVICES	**PeiServices,
need consistent spacing around '*' (ctx:WxO)



-- 
To view, visit https://review.coreboot.org/25634
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie844e3f15f759ea09a8f3fd24825ee740151c956
Gerrit-Change-Number: 25634
Gerrit-PatchSet: 34
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Idwer Vollering <vidwer at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Ronald G. Minnich <rminnich at gmail.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin at chromium.org>
Gerrit-CC: Furquan Shaikh <furquan at google.com>
Gerrit-CC: Nathaniel L Desimone <nathaniel.l.desimone at intel.com>
Gerrit-Comment-Date: Fri, 25 May 2018 06:38:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180525/2f199373/attachment.html>