[coreboot-gerrit] Change in coreboot[master]: sb/intel/bd82x6x: Get rid of device_t

Fri May 25 08:36:27 CEST 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26530 )

Change subject: sb/intel/bd82x6x: Get rid of device_t
......................................................................

Patch Set 1:

(24 comments)

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/azalia.c
File src/southbridge/intel/bd82x6x/azalia.c:

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/azalia.c@340
PS1, Line 340: static void azalia_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
line over 80 characters

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/azalia.c@340
PS1, Line 340: static void azalia_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/azalia.c@340
PS1, Line 340: static void azalia_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/lpc.c
File src/southbridge/intel/bd82x6x/lpc.c:

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/lpc.c@643
PS1, Line 643: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/lpc.c@643
PS1, Line 643: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/lpc.c@687
PS1, Line 687: 	struct device *dev = dev_find_slot(0, PCI_DEVFN(0x1f,0));
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/lpc.c@824
PS1, Line 824: 	struct device *dev = dev_find_slot(0, PCI_DEVFN(0x1f,0));
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/pci.c
File src/southbridge/intel/bd82x6x/pci.c:

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/pci.c@103
PS1, Line 103: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/pci.c@103
PS1, Line 103: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/pcie.c
File src/southbridge/intel/bd82x6x/pcie.c:

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/pcie.c@309
PS1, Line 309: static void pcie_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
line over 80 characters

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/pcie.c@309
PS1, Line 309: static void pcie_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/pcie.c@309
PS1, Line 309: static void pcie_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/sata.c
File src/southbridge/intel/bd82x6x/sata.c:

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/sata.c@236
PS1, Line 236: static void sata_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
line over 80 characters

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/sata.c@236
PS1, Line 236: static void sata_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/sata.c@236
PS1, Line 236: static void sata_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/smbus.c
File src/southbridge/intel/bd82x6x/smbus.c:

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/smbus.c@75
PS1, Line 75: static void smbus_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
line over 80 characters

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/smbus.c@75
PS1, Line 75: static void smbus_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/smbus.c@75
PS1, Line 75: static void smbus_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/usb_ehci.c
File src/southbridge/intel/bd82x6x/usb_ehci.c:

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/usb_ehci.c@77
PS1, Line 77: static void usb_ehci_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
line over 80 characters

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/usb_ehci.c@77
PS1, Line 77: static void usb_ehci_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/usb_ehci.c@77
PS1, Line 77: static void usb_ehci_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/usb_xhci.c
File src/southbridge/intel/bd82x6x/usb_xhci.c:

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/usb_xhci.c@59
PS1, Line 59: static void xhci_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
line over 80 characters

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/usb_xhci.c@59
PS1, Line 59: static void xhci_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'

https://review.coreboot.org/#/c/26530/1/src/southbridge/intel/bd82x6x/usb_xhci.c@59
PS1, Line 59: static void xhci_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'

-- 
To view, visit https://review.coreboot.org/26530
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05f23504148d934109814b8f3c1c2a334366496a
Gerrit-Change-Number: 26530
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 25 May 2018 06:36:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180525/46918002/attachment.html>