[coreboot-gerrit] Change in coreboot[master]: elog: Allow calling boot_count_read() without CONFIG_ELOG_BOOT_COUNT

Daniel Kurtz (Code Review) gerrit at coreboot.org
Fri May 25 02:24:53 CEST 2018


Hello Daniel Kurtz,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/26526

to review the following change.


Change subject: elog: Allow calling boot_count_read() without CONFIG_ELOG_BOOT_COUNT
......................................................................

elog: Allow calling boot_count_read() without CONFIG_ELOG_BOOT_COUNT

Have boot_count_read() just return 0 if CONFIG_ELOG_BOOT_COUNT is not
enabled.

BUG=b:79865267
TEST=firmware_EventLog

Change-Id: I70f16226371324dea37b3f36f85c2037e324ef31
Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
---
M src/include/elog.h
1 file changed, 7 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/26526/1

diff --git a/src/include/elog.h b/src/include/elog.h
index 0f6a811..0776c36 100644
--- a/src/include/elog.h
+++ b/src/include/elog.h
@@ -250,7 +250,14 @@
 
 extern u32 gsmi_exec(u8 command, u32 *param);
 
+#if IS_ENABLED(CONFIG_ELOG_BOOT_COUNT)
 u32 boot_count_read(void);
+#else
+static inline u32 boot_count_read(void)
+{
+	return 0;
+}
+#endif
 u32 boot_count_increment(void);
 
 /*

-- 
To view, visit https://review.coreboot.org/26526
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I70f16226371324dea37b3f36f85c2037e324ef31
Gerrit-Change-Number: 26526
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180525/19bf89a3/attachment.html>


More information about the coreboot-gerrit mailing list