[coreboot-gerrit] Change in coreboot[master]: elog: Only print TYPE_BOOT on S3-resume if CONFIG_ELOG_BOOT_COUNT

[Daniel Kurtz (Code Review)]

Hello Daniel Kurtz,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/26527

to review the following change.


Change subject: elog: Only print TYPE_BOOT on S3-resume if CONFIG_ELOG_BOOT_COUNT
......................................................................

elog: Only print TYPE_BOOT on S3-resume if CONFIG_ELOG_BOOT_COUNT

Previously, we were unconditionally adding a TYPE_BOOT message to the ELOG
on every boot (even S3 resume) if CONFIG_ELOG_BOOT_COUNT was disabled.
Now that boot_count_read() returns 0 for the !CONFIG_ELOG_BOOT_COUNT
case, the code becomes a bit simpler.

BUG=b:79865267
TEST=firmware_EventLog

Change-Id: I803fa4c3e03b6cc94751cf0ce34b78021ae2124e
Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
---
M src/drivers/elog/elog.c
1 file changed, 1 insertion(+), 6 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/26527/1

diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c
index c8f221a..ff4f036 100644
--- a/src/drivers/elog/elog.c
+++ b/src/drivers/elog/elog.c
@@ -786,15 +786,10 @@
 
 #if !defined(__SMM__)
 	/* Log boot count event except in S3 resume */
-#if IS_ENABLED(CONFIG_ELOG_BOOT_COUNT)
 #if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME)
-		if (!acpi_is_wakeup_s3())
+	if (!acpi_is_wakeup_s3())
 #endif
 		elog_add_event_dword(ELOG_TYPE_BOOT, boot_count_read());
-#else
-		/* If boot count is not implemented, fake it. */
-		elog_add_event_dword(ELOG_TYPE_BOOT, 0);
-#endif
 
 #if IS_ENABLED(CONFIG_ARCH_X86)
 	/* Check and log POST codes from previous boot */

-- 
To view, visit https://review.coreboot.org/26527
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I803fa4c3e03b6cc94751cf0ce34b78021ae2124e
Gerrit-Change-Number: 26527
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180525/8bea8f12/attachment-0001.html>