[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Increment boot_count on non-S3 boots.

Daniel Kurtz (Code Review) gerrit at coreboot.org
Fri May 25 02:24:52 CEST 2018


Hello Daniel Kurtz,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/26525

to review the following change.


Change subject: soc/amd/stoneyridge: Increment boot_count on non-S3 boots.
......................................................................

soc/amd/stoneyridge: Increment boot_count on non-S3 boots.

Increment the boot_count from romstage when not resuming from S3.

BUG=b:80266624
TEST=firmware_EventLog
TEST=boot, then:
   mosys eventlog list | grep boot
1 | 2018-05-24 16:51:42 | System boot | 1
   reboot
   mosys eventlog list | grep boot
1 | 2018-05-24 16:51:42 | System boot | 1
6 | 2018-05-24 16:52:34 | System boot | 2

Change-Id: Ideec9da809e494fb0ea073f648540285972f8238
Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
---
M src/soc/amd/stoneyridge/romstage.c
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/26525/1

diff --git a/src/soc/amd/stoneyridge/romstage.c b/src/soc/amd/stoneyridge/romstage.c
index 0e019f7..179168b 100644
--- a/src/soc/amd/stoneyridge/romstage.c
+++ b/src/soc/amd/stoneyridge/romstage.c
@@ -28,6 +28,7 @@
 #include <chip.h>
 #include <program_loading.h>
 #include <romstage_handoff.h>
+#include <elog.h>
 #include <amdblocks/agesawrapper.h>
 #include <amdblocks/agesawrapper_call.h>
 #include <soc/northbridge.h>
@@ -94,6 +95,8 @@
 		msr_t sys_cfg = rdmsr(SYSCFG_MSR);
 		sys_cfg.lo &= ~SYSCFG_MSR_TOM2WB;
 		wrmsr(SYSCFG_MSR, sys_cfg);
+		if (IS_ENABLED(CONFIG_ELOG_BOOT_COUNT))
+			boot_count_increment();
 	} else {
 		printk(BIOS_INFO, "S3 detected\n");
 		post_code(0x60);

-- 
To view, visit https://review.coreboot.org/26525
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ideec9da809e494fb0ea073f648540285972f8238
Gerrit-Change-Number: 26525
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180525/a3230101/attachment.html>


More information about the coreboot-gerrit mailing list