[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Record ACPI Wake events in ELOG

Daniel Kurtz (Code Review) gerrit at coreboot.org
Fri May 25 00:13:15 CEST 2018


Hello Daniel Kurtz,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/26522

to review the following change.


Change subject: soc/amd/stoneyridge: Record ACPI Wake events in ELOG
......................................................................

soc/amd/stoneyridge: Record ACPI Wake events in ELOG

We are already reporting the Wake source, but we must also report the
ACPI wake itself.

BUG=b:79865267
TEST=firmware_EventLog

Change-Id: Id26dff46379800a63ab9b77f135d23c6382f77e6
Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
---
M src/soc/amd/stoneyridge/southbridge.c
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/26522/1

diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c
index f01f534..5a3a442 100644
--- a/src/soc/amd/stoneyridge/southbridge.c
+++ b/src/soc/amd/stoneyridge/southbridge.c
@@ -669,6 +669,10 @@
 	if (!IS_ENABLED(CONFIG_ELOG))
 		return;
 
+	if (pm1_sts & WAK_STS)
+		elog_add_event_byte(ELOG_TYPE_ACPI_WAKE,
+				    acpi_is_wakeup_s3() ? ACPI_S3 : ACPI_S5);
+
 	if (pm1_sts & PWRBTN_STS)
 		elog_add_event_wake(ELOG_WAKE_SOURCE_PWRBTN, 0);
 

-- 
To view, visit https://review.coreboot.org/26522
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id26dff46379800a63ab9b77f135d23c6382f77e6
Gerrit-Change-Number: 26522
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180524/bb1d83af/attachment.html>


More information about the coreboot-gerrit mailing list