[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Configure LPC_CLKRUN# pin as GPIO to allow S0ix...

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23742 )

Change subject: soc/intel/apollolake: Configure LPC_CLKRUN# pin as GPIO to allow S0ix entry
......................................................................


Patch Set 5:

(3 comments)

https://review.coreboot.org/#/c/23742/5/src/mainboard/google/octopus/variants/baseboard/gpio.c
File src/mainboard/google/octopus/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/23742/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@211
PS5, Line 211: 	PAD_NC(GPIO_154, NONE),/*LPC_CLKRUNB -- unused but needs to be in GPIO mode for ESPI*/
line over 80 characters


https://review.coreboot.org/#/c/23742/5/src/mainboard/google/octopus/variants/bip/gpio.c
File src/mainboard/google/octopus/variants/bip/gpio.c:

https://review.coreboot.org/#/c/23742/5/src/mainboard/google/octopus/variants/bip/gpio.c@209
PS5, Line 209: 	PAD_NC(GPIO_154, NONE),/*LPC_CLKRUNB -- unused but needs to be in GPIO mode for ESPI*/
line over 80 characters


https://review.coreboot.org/#/c/23742/5/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c
File src/mainboard/intel/glkrvp/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/23742/5/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c@193
PS5, Line 193: 	PAD_NC(GPIO_154, NONE),/*LPC_CLKRUNB -- unused but needs to be in GPIO mode for ESPI*/
line over 80 characters



-- 
To view, visit https://review.coreboot.org/23742
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0c1013fee638a3b7a91469736efc0c25a1597fa
Gerrit-Change-Number: 23742
Gerrit-PatchSet: 5
Gerrit-Owner: Shamile Khan <shamile.khan at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shamile Khan <shamile.khan at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 24 May 2018 20:57:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180524/c494e98a/attachment.html>