[coreboot-gerrit] Change in coreboot[master]: soc/intel/braswell: Get rid of device_t

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Thu May 24 22:31:43 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26457 )

Change subject: soc/intel/braswell: Get rid of device_t
......................................................................


Patch Set 5:

(5 comments)

https://review.coreboot.org/#/c/26457/5/src/soc/intel/braswell/gfx.c
File src/soc/intel/braswell/gfx.c:

https://review.coreboot.org/#/c/26457/5/src/soc/intel/braswell/gfx.c@44
PS5, Line 44: static inline void gfx_run_script(struct device *dev, const struct reg_script *ops)
line over 80 characters


https://review.coreboot.org/#/c/26457/5/src/soc/intel/braswell/lpe.c
File src/soc/intel/braswell/lpe.c:

https://review.coreboot.org/#/c/26457/5/src/soc/intel/braswell/lpe.c@47
PS5, Line 47: static void assign_device_nvs(struct device *dev, u32 *field, unsigned int index)
line over 80 characters


https://review.coreboot.org/#/c/26457/5/src/soc/intel/braswell/lpss.c
File src/soc/intel/braswell/lpss.c:

https://review.coreboot.org/#/c/26457/5/src/soc/intel/braswell/lpss.c@33
PS5, Line 33: static void dev_enable_acpi_mode(struct device *dev, int iosf_reg, int nvs_index)
line over 80 characters


https://review.coreboot.org/#/c/26457/5/src/soc/intel/braswell/southcluster.c
File src/soc/intel/braswell/southcluster.c:

https://review.coreboot.org/#/c/26457/5/src/soc/intel/braswell/southcluster.c@56
PS5, Line 56: add_mmio_resource(struct device *dev, int i, unsigned long addr, unsigned long size)
line over 80 characters


https://review.coreboot.org/#/c/26457/5/src/soc/intel/braswell/southcluster.c@100
PS5, Line 100: static void sc_add_io_resource(struct device *dev, int base, int size, int index)
line over 80 characters



-- 
To view, visit https://review.coreboot.org/26457
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05a46ab0ae6b4493895c1231fedb59c96efdf793
Gerrit-Change-Number: 26457
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 24 May 2018 20:31:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180524/fa42d640/attachment.html>


More information about the coreboot-gerrit mailing list