[coreboot-gerrit] Change in coreboot[master]: soc/intel/baytrail: Get rid of device_t

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Thu May 24 20:24:32 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26456 )

Change subject: soc/intel/baytrail: Get rid of device_t
......................................................................


Patch Set 4:

(5 comments)

https://review.coreboot.org/#/c/26456/4/src/soc/intel/baytrail/chip.c
File src/soc/intel/baytrail/chip.c:

https://review.coreboot.org/#/c/26456/4/src/soc/intel/baytrail/chip.c@75
PS4, Line 75: static void pci_set_subsystem(struct device *dev, unsigned vendor,
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26456/4/src/soc/intel/baytrail/chip.c@76
PS4, Line 76: 			      unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26456/4/src/soc/intel/baytrail/lpe.c
File src/soc/intel/baytrail/lpe.c:

https://review.coreboot.org/#/c/26456/4/src/soc/intel/baytrail/lpe.c@44
PS4, Line 44: static void assign_device_nvs(struct device *dev, u32 *field, unsigned index)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26456/4/src/soc/intel/baytrail/pcie.c
File src/soc/intel/baytrail/pcie.c:

https://review.coreboot.org/#/c/26456/4/src/soc/intel/baytrail/pcie.c@242
PS4, Line 242: static void pcie_root_set_subsystem(struct device *dev, unsigned vid,
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26456/4/src/soc/intel/baytrail/pcie.c@243
PS4, Line 243: 				    unsigned did)
Prefer 'unsigned int' to bare use of 'unsigned'



-- 
To view, visit https://review.coreboot.org/26456
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b2cfe3e2090fb8eed755e40d337c6049d8dd96e
Gerrit-Change-Number: 26456
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Thu, 24 May 2018 18:24:32 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180524/076ebe34/attachment.html>


More information about the coreboot-gerrit mailing list