[coreboot-gerrit] Change in coreboot[master]: Update Max98373's I/V capture and DSM configuration
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Thu May 24 20:16:52 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26384 )
Change subject: Update Max98373's I/V capture and DSM configuration
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/26384/2/src/drivers/i2c/max98373/max98373.c
File src/drivers/i2c/max98373/max98373.c:
https://review.coreboot.org/#/c/26384/2/src/drivers/i2c/max98373/max98373.c@65
PS2, Line 65: if( config->interleave_mode)
space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/26384/2/src/drivers/i2c/max98373/max98373.c@65
PS2, Line 65: if( config->interleave_mode)
space required before the open parenthesis '('
--
To view, visit https://review.coreboot.org/26384
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75434a63fe030ed9bb963c6d300d833a8e7d2d66
Gerrit-Change-Number: 26384
Gerrit-PatchSet: 2
Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Naveen Manohar <naveen.m at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Sathya Prakash M R <sathya.prakash.m.r at intel.com>
Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 24 May 2018 18:16:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180524/7557aac8/attachment.html>
More information about the coreboot-gerrit
mailing list