[coreboot-gerrit] Change in coreboot[master]: sb/ti/pci{1x2x, i7420, xx12}: Get rid of device_t

Patrick Georgi (Code Review) gerrit at coreboot.org
Tue May 22 09:18:14 CEST 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/26397 )

Change subject: sb/ti/pci{1x2x,i7420,xx12}: Get rid of device_t
......................................................................

sb/ti/pci{1x2x,i7420,xx12}: Get rid of device_t

Use of device_t has been abandoned in ramstage.

Change-Id: I37c6db65be4477dabb6064c3cc7ea1c63e467d19
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
Reviewed-on: https://review.coreboot.org/26397
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
---
M src/southbridge/ti/pci1x2x/pci1x2x.c
M src/southbridge/ti/pci7420/cardbus.c
M src/southbridge/ti/pci7420/firewire.c
M src/southbridge/ti/pcixx12/pcixx12.c
4 files changed, 12 insertions(+), 11 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved



diff --git a/src/southbridge/ti/pci1x2x/pci1x2x.c b/src/southbridge/ti/pci1x2x/pci1x2x.c
index 883f00f..e670a43 100644
--- a/src/southbridge/ti/pci1x2x/pci1x2x.c
+++ b/src/southbridge/ti/pci1x2x/pci1x2x.c
@@ -39,7 +39,8 @@
 	pci_write_config8(dev, 0x92, pci_read_config8(dev, 0x92) | 0x02);
 }
 
-static void ti_pci1x2y_set_subsystem(device_t dev, unsigned vendor, unsigned device)
+static void ti_pci1x2y_set_subsystem(struct device *dev, unsigned vendor,
+				     unsigned device)
 {
 	/*
 	 * Enable change sub-vendor ID. Clear the bit 5 to enable to write
diff --git a/src/southbridge/ti/pci7420/cardbus.c b/src/southbridge/ti/pci7420/cardbus.c
index ce807dd..910b0c8 100644
--- a/src/southbridge/ti/pci7420/cardbus.c
+++ b/src/southbridge/ti/pci7420/cardbus.c
@@ -28,7 +28,7 @@
 static int cardbus_count = 0;
 #endif
 
-static void pci7420_cardbus_init(device_t dev)
+static void pci7420_cardbus_init(struct device *dev)
 {
 	u8 reg8;
 	u16 reg16;
@@ -79,12 +79,12 @@
 #endif
 }
 
-static void pci7420_cardbus_read_resources(device_t dev)
+static void pci7420_cardbus_read_resources(struct device *dev)
 {
 	cardbus_read_resources(dev);
 }
 
-static void pci7420_cardbus_set_resources(device_t dev)
+static void pci7420_cardbus_set_resources(struct device *dev)
 {
 	printk(BIOS_DEBUG, "%s In set resources\n",dev_path(dev));
 
@@ -113,7 +113,7 @@
 	.device = 0xac8d,
 };
 
-static void ti_pci7420_enable_dev(device_t dev)
+static void ti_pci7420_enable_dev(struct device *dev)
 {
 	/* Nothing here yet */
 }
diff --git a/src/southbridge/ti/pci7420/firewire.c b/src/southbridge/ti/pci7420/firewire.c
index 2f67141..e42b6a6 100644
--- a/src/southbridge/ti/pci7420/firewire.c
+++ b/src/southbridge/ti/pci7420/firewire.c
@@ -24,7 +24,7 @@
 #include "pci7420.h"
 #include "chip.h"
 
-static void pci7420_firewire_init(device_t dev)
+static void pci7420_firewire_init(struct device *dev)
 {
 	printk(BIOS_DEBUG, "TI PCI7420/7620 FireWire init\n");
 
@@ -51,7 +51,7 @@
 	.device = 0x802e,
 };
 
-static void ti_pci7420_firewire_enable_dev(device_t dev)
+static void ti_pci7420_firewire_enable_dev(struct device *dev)
 {
 	/* Nothing here yet */
 }
diff --git a/src/southbridge/ti/pcixx12/pcixx12.c b/src/southbridge/ti/pcixx12/pcixx12.c
index 91d4885..ab7231e 100644
--- a/src/southbridge/ti/pcixx12/pcixx12.c
+++ b/src/southbridge/ti/pcixx12/pcixx12.c
@@ -21,18 +21,18 @@
 #include <console/console.h>
 #include <device/cardbus.h>
 
-static void pcixx12_init(device_t dev)
+static void pcixx12_init(struct device *dev)
 {
 	/* cardbus controller function 1 for CF Socket */
 	printk(BIOS_DEBUG, "TI PCIxx12 init\n");
 }
 
-static void pcixx12_read_resources(device_t dev)
+static void pcixx12_read_resources(struct device *dev)
 {
 	cardbus_read_resources(dev);
 }
 
-static void pcixx12_set_resources(device_t dev)
+static void pcixx12_set_resources(struct device *dev)
 {
 	printk(BIOS_DEBUG, "%s In set resources\n",dev_path(dev));
 
@@ -55,7 +55,7 @@
 	.device = 0x8039,
 };
 
-static void southbridge_init(device_t dev)
+static void southbridge_init(struct device *dev)
 {
 }
 

-- 
To view, visit https://review.coreboot.org/26397
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I37c6db65be4477dabb6064c3cc7ea1c63e467d19
Gerrit-Change-Number: 26397
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180522/69659c96/attachment.html>


More information about the coreboot-gerrit mailing list