[coreboot-gerrit] Change in coreboot[master]: util/intelmetool: Add Makefile target for OLDARC definition

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/26450 )

Change subject: util/intelmetool: Add Makefile target for OLDARC definition
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/26450/1/util/intelmetool/Makefile
File util/intelmetool/Makefile:

https://review.coreboot.org/#/c/26450/1/util/intelmetool/Makefile@41
PS1, Line 41: oldarc: all
            : oldarc: CFLAGS += -DOLDARC
Could you switch the order on these? It just seems more intuitive to have the target specific variable set first.



-- 
To view, visit https://review.coreboot.org/26450
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb0da7663e795f790e2723bb334447380724b56
Gerrit-Change-Number: 26450
Gerrit-PatchSet: 1
Gerrit-Owner: Matthias Gazzari <mail at qtux.eu>
Gerrit-Reviewer: Matthias Gazzari <mail at qtux.eu>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-Comment-Date: Mon, 21 May 2018 19:04:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180521/81568ed9/attachment.html>