[coreboot-gerrit] Change in coreboot[master]: northbridge/intel: Use different name for variables and structs
Elyes HAOUAS (Code Review)
gerrit at coreboot.org
Mon May 21 10:22:30 CEST 2018
Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26445
Change subject: northbridge/intel: Use different name for variables and structs
......................................................................
northbridge/intel: Use different name for variables and structs
My previous changes 'Get ride of device_t' introduced a
confusion by using the same name for variables and structs.
Change-Id: I7639118913864826a2d7d932795834606865171b
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/northbridge/intel/fsp_rangeley/acpi.c
M src/northbridge/intel/fsp_rangeley/northbridge.h
M src/northbridge/intel/fsp_sandybridge/gma.c
M src/northbridge/intel/gm45/acpi.c
M src/northbridge/intel/gm45/gm45.h
M src/northbridge/intel/gm45/gma.c
M src/northbridge/intel/haswell/gma.c
M src/northbridge/intel/haswell/haswell.h
M src/northbridge/intel/i945/gma.c
M src/northbridge/intel/nehalem/gma.c
M src/northbridge/intel/sandybridge/gma.c
M src/northbridge/intel/sandybridge/sandybridge.h
M src/northbridge/intel/x4x/acpi.c
M src/northbridge/intel/x4x/gma.c
M src/northbridge/intel/x4x/x4x.h
15 files changed, 15 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/26445/1
diff --git a/src/northbridge/intel/fsp_rangeley/acpi.c b/src/northbridge/intel/fsp_rangeley/acpi.c
index c8e6d45..f86c891 100644
--- a/src/northbridge/intel/fsp_rangeley/acpi.c
+++ b/src/northbridge/intel/fsp_rangeley/acpi.c
@@ -61,7 +61,7 @@
return current;
}
-void northbridge_acpi_fill_ssdt_generator(struct device *device)
+void northbridge_acpi_fill_ssdt_generator(struct device *dev)
{
u32 bmbound;
char pscope[] = "\\_SB.PCI0";
diff --git a/src/northbridge/intel/fsp_rangeley/northbridge.h b/src/northbridge/intel/fsp_rangeley/northbridge.h
index f68d175..ac75f2c 100644
--- a/src/northbridge/intel/fsp_rangeley/northbridge.h
+++ b/src/northbridge/intel/fsp_rangeley/northbridge.h
@@ -73,7 +73,7 @@
void report_platform_info(void);
#ifndef __SIMPLE_DEVICE__
-void northbridge_acpi_fill_ssdt_generator(struct device *device);
+void northbridge_acpi_fill_ssdt_generator(struct device *dev);
#endif
#endif /* #ifndef __ASSEMBLER__ */
diff --git a/src/northbridge/intel/fsp_sandybridge/gma.c b/src/northbridge/intel/fsp_sandybridge/gma.c
index 2cfd1f3..c6caf04 100644
--- a/src/northbridge/intel/fsp_sandybridge/gma.c
+++ b/src/northbridge/intel/fsp_sandybridge/gma.c
@@ -89,7 +89,7 @@
return &chip->gfx;
}
-static void gma_ssdt(struct device *device)
+static void gma_ssdt(struct device *dev)
{
const struct i915_gpu_controller_info *gfx = intel_gma_get_controller_info();
if (!gfx) {
diff --git a/src/northbridge/intel/gm45/acpi.c b/src/northbridge/intel/gm45/acpi.c
index 73b098f..fd45adb 100644
--- a/src/northbridge/intel/gm45/acpi.c
+++ b/src/northbridge/intel/gm45/acpi.c
@@ -105,7 +105,7 @@
return current;
}
-unsigned long northbridge_write_acpi_tables(struct device *device,
+unsigned long northbridge_write_acpi_tables(struct device *dev,
unsigned long start,
struct acpi_rsdp *rsdp)
{
diff --git a/src/northbridge/intel/gm45/gm45.h b/src/northbridge/intel/gm45/gm45.h
index 56c6fea..c0fccde 100644
--- a/src/northbridge/intel/gm45/gm45.h
+++ b/src/northbridge/intel/gm45/gm45.h
@@ -448,7 +448,7 @@
#include <device/device.h>
struct acpi_rsdp;
-unsigned long northbridge_write_acpi_tables(struct device *device, unsigned long start, struct acpi_rsdp *rsdp);
+unsigned long northbridge_write_acpi_tables(struct device *dev, unsigned long start, struct acpi_rsdp *rsdp);
#endif
#endif /* !__ACPI__ */
diff --git a/src/northbridge/intel/gm45/gma.c b/src/northbridge/intel/gm45/gma.c
index 237071c..361c249 100644
--- a/src/northbridge/intel/gm45/gma.c
+++ b/src/northbridge/intel/gm45/gma.c
@@ -801,7 +801,7 @@
return &chip->gfx;
}
-static void gma_ssdt(struct device *device)
+static void gma_ssdt(struct device *dev)
{
const struct i915_gpu_controller_info *gfx = intel_gma_get_controller_info();
if (!gfx) {
diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c
index 8ffdce8..996345f 100644
--- a/src/northbridge/intel/haswell/gma.c
+++ b/src/northbridge/intel/haswell/gma.c
@@ -510,7 +510,7 @@
return &chip->gfx;
}
-static void gma_ssdt(struct device *device)
+static void gma_ssdt(struct device *dev)
{
const struct i915_gpu_controller_info *gfx = intel_gma_get_controller_info();
if (!gfx) {
diff --git a/src/northbridge/intel/haswell/haswell.h b/src/northbridge/intel/haswell/haswell.h
index d8868a1..88b2222 100644
--- a/src/northbridge/intel/haswell/haswell.h
+++ b/src/northbridge/intel/haswell/haswell.h
@@ -234,7 +234,7 @@
#include <device/device.h>
struct acpi_rsdp;
-unsigned long northbridge_write_acpi_tables(struct device *device,
+unsigned long northbridge_write_acpi_tables(struct device *dev,
unsigned long start, struct acpi_rsdp *rsdp);
#endif
diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c
index 6c3d6ae..8d9508b 100644
--- a/src/northbridge/intel/i945/gma.c
+++ b/src/northbridge/intel/i945/gma.c
@@ -770,7 +770,7 @@
return &chip->gfx;
}
-static void gma_ssdt(struct device *device)
+static void gma_ssdt(struct device *dev)
{
const struct i915_gpu_controller_info *gfx = intel_gma_get_controller_info();
if (!gfx)
diff --git a/src/northbridge/intel/nehalem/gma.c b/src/northbridge/intel/nehalem/gma.c
index 6b8b98e..f4a4aef 100644
--- a/src/northbridge/intel/nehalem/gma.c
+++ b/src/northbridge/intel/nehalem/gma.c
@@ -1122,7 +1122,7 @@
return &chip->gfx;
}
-static void gma_ssdt(struct device *device)
+static void gma_ssdt(struct device *dev)
{
const struct i915_gpu_controller_info *gfx = intel_gma_get_controller_info();
if (!gfx) {
diff --git a/src/northbridge/intel/sandybridge/gma.c b/src/northbridge/intel/sandybridge/gma.c
index 201498a..86f843e 100644
--- a/src/northbridge/intel/sandybridge/gma.c
+++ b/src/northbridge/intel/sandybridge/gma.c
@@ -684,7 +684,7 @@
return &chip->gfx;
}
-static void gma_ssdt(struct device *device)
+static void gma_ssdt(struct device *dev)
{
const struct i915_gpu_controller_info *gfx = intel_gma_get_controller_info();
if (!gfx) {
diff --git a/src/northbridge/intel/sandybridge/sandybridge.h b/src/northbridge/intel/sandybridge/sandybridge.h
index e81d3bf..75195c5 100644
--- a/src/northbridge/intel/sandybridge/sandybridge.h
+++ b/src/northbridge/intel/sandybridge/sandybridge.h
@@ -230,7 +230,7 @@
#include <device/device.h>
struct acpi_rsdp;
-unsigned long northbridge_write_acpi_tables(struct device *device, unsigned long start, struct acpi_rsdp *rsdp);
+unsigned long northbridge_write_acpi_tables(struct device *dev, unsigned long start, struct acpi_rsdp *rsdp);
#endif
#endif
diff --git a/src/northbridge/intel/x4x/acpi.c b/src/northbridge/intel/x4x/acpi.c
index 678486c..b9fb739 100644
--- a/src/northbridge/intel/x4x/acpi.c
+++ b/src/northbridge/intel/x4x/acpi.c
@@ -44,7 +44,7 @@
return current;
}
-unsigned long northbridge_write_acpi_tables(struct device *device,
+unsigned long northbridge_write_acpi_tables(struct device *dev,
unsigned long start,
struct acpi_rsdp *rsdp)
{
diff --git a/src/northbridge/intel/x4x/gma.c b/src/northbridge/intel/x4x/gma.c
index 8ce1a5d..11ba378 100644
--- a/src/northbridge/intel/x4x/gma.c
+++ b/src/northbridge/intel/x4x/gma.c
@@ -453,7 +453,7 @@
return &chip->gfx;
}
-static void gma_ssdt(struct device *device)
+static void gma_ssdt(struct device *dev)
{
const struct i915_gpu_controller_info *gfx = intel_gma_get_controller_info();
if (!gfx)
diff --git a/src/northbridge/intel/x4x/x4x.h b/src/northbridge/intel/x4x/x4x.h
index 8532d60..0104bc7 100644
--- a/src/northbridge/intel/x4x/x4x.h
+++ b/src/northbridge/intel/x4x/x4x.h
@@ -391,7 +391,7 @@
struct acpi_rsdp;
#ifndef __SIMPLE_DEVICE__
-unsigned long northbridge_write_acpi_tables(struct device *device,
+unsigned long northbridge_write_acpi_tables(struct device *dev,
unsigned long start, struct acpi_rsdp *rsdp);
#endif /* __SIMPLE_DEVICE__ */
#endif
--
To view, visit https://review.coreboot.org/26445
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7639118913864826a2d7d932795834606865171b
Gerrit-Change-Number: 26445
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180521/e8b90183/attachment-0001.html>
More information about the coreboot-gerrit
mailing list