[coreboot-gerrit] Change in coreboot[master]: src/mainboard: Use different name for variables and structs
Elyes HAOUAS (Code Review)
gerrit at coreboot.org
Mon May 21 10:22:28 CEST 2018
Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26443
Change subject: src/mainboard: Use different name for variables and structs
......................................................................
src/mainboard: Use different name for variables and structs
My previous changes 'Get ride of device_t' introduced a
confusion by using the same name for variables and structs.
Change-Id: I11ca08a4e4947633c03f5382467dec54fd632780
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/mainboard/amd/serengeti_cheetah/mainboard.h
M src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c
M src/mainboard/amd/serengeti_cheetah_fam10/mainboard.h
M src/mainboard/getac/p470/acpi_tables.c
M src/mainboard/getac/p470/mainboard.h
M src/mainboard/google/chell/mainboard.c
M src/mainboard/google/eve/mainboard.c
M src/mainboard/google/fizz/mainboard.c
M src/mainboard/google/glados/mainboard.c
M src/mainboard/google/lars/mainboard.c
M src/mainboard/google/octopus/mainboard.c
M src/mainboard/google/poppy/mainboard.c
M src/mainboard/google/reef/mainboard.c
M src/mainboard/google/zoombini/mainboard.c
M src/mainboard/intel/kunimitsu/mainboard.c
M src/mainboard/iwill/dk8_htx/acpi_tables.c
M src/mainboard/iwill/dk8_htx/mainboard.h
M src/mainboard/lenovo/x200/mainboard.c
M src/mainboard/lenovo/x201/mainboard.c
M src/mainboard/lenovo/x60/mainboard.c
M src/mainboard/siemens/sitemp_g1p1/acpi_tables.c
21 files changed, 21 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/26443/1
diff --git a/src/mainboard/amd/serengeti_cheetah/mainboard.h b/src/mainboard/amd/serengeti_cheetah/mainboard.h
index 2613374..dbc9806 100644
--- a/src/mainboard/amd/serengeti_cheetah/mainboard.h
+++ b/src/mainboard/amd/serengeti_cheetah/mainboard.h
@@ -11,4 +11,4 @@
* GNU General Public License for more details.
*/
-unsigned long mainboard_write_acpi_tables(struct device *device, unsigned long start, acpi_rsdp_t *rsdp);
+unsigned long mainboard_write_acpi_tables(struct device *dev, unsigned long start, acpi_rsdp_t *rsdp);
diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c b/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c
index e355aae..edb27fb 100644
--- a/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c
+++ b/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c
@@ -119,7 +119,7 @@
return current;
}
-unsigned long mainboard_write_acpi_tables(struct device *device,
+unsigned long mainboard_write_acpi_tables(struct device *dev,
unsigned long current,
acpi_rsdp_t *rsdp)
{
diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/mainboard.h b/src/mainboard/amd/serengeti_cheetah_fam10/mainboard.h
index 2613374..dbc9806 100644
--- a/src/mainboard/amd/serengeti_cheetah_fam10/mainboard.h
+++ b/src/mainboard/amd/serengeti_cheetah_fam10/mainboard.h
@@ -11,4 +11,4 @@
* GNU General Public License for more details.
*/
-unsigned long mainboard_write_acpi_tables(struct device *device, unsigned long start, acpi_rsdp_t *rsdp);
+unsigned long mainboard_write_acpi_tables(struct device *dev, unsigned long start, acpi_rsdp_t *rsdp);
diff --git a/src/mainboard/getac/p470/acpi_tables.c b/src/mainboard/getac/p470/acpi_tables.c
index f840605..3dacadc 100644
--- a/src/mainboard/getac/p470/acpi_tables.c
+++ b/src/mainboard/getac/p470/acpi_tables.c
@@ -81,7 +81,7 @@
return header->length;
}
-unsigned long mainboard_write_acpi_tables(struct device *device,
+unsigned long mainboard_write_acpi_tables(struct device *dev,
unsigned long start,
acpi_rsdp_t *rsdp)
{
diff --git a/src/mainboard/getac/p470/mainboard.h b/src/mainboard/getac/p470/mainboard.h
index 3d155c8..0fd7fde 100644
--- a/src/mainboard/getac/p470/mainboard.h
+++ b/src/mainboard/getac/p470/mainboard.h
@@ -1,5 +1,5 @@
struct acpi_rsdp;
-unsigned long mainboard_write_acpi_tables(struct device *device,
+unsigned long mainboard_write_acpi_tables(struct device *dev,
unsigned long start,
struct acpi_rsdp *rsdp);
diff --git a/src/mainboard/google/chell/mainboard.c b/src/mainboard/google/chell/mainboard.c
index e2cf9ad..920435b 100644
--- a/src/mainboard/google/chell/mainboard.c
+++ b/src/mainboard/google/chell/mainboard.c
@@ -29,7 +29,7 @@
}
static unsigned long mainboard_write_acpi_tables(
- struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
+ struct device *dev, unsigned long current, acpi_rsdp_t *rsdp)
{
uintptr_t start_addr;
uintptr_t end_addr;
diff --git a/src/mainboard/google/eve/mainboard.c b/src/mainboard/google/eve/mainboard.c
index 63dcd75..d7ef1f6 100644
--- a/src/mainboard/google/eve/mainboard.c
+++ b/src/mainboard/google/eve/mainboard.c
@@ -32,7 +32,7 @@
}
static unsigned long mainboard_write_acpi_tables(
- struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
+ struct device *dev, unsigned long current, acpi_rsdp_t *rsdp)
{
uintptr_t start_addr;
uintptr_t end_addr;
diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c
index eb48e40..27639be 100644
--- a/src/mainboard/google/fizz/mainboard.c
+++ b/src/mainboard/google/fizz/mainboard.c
@@ -233,7 +233,7 @@
}
static unsigned long mainboard_write_acpi_tables(
- struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
+ struct device *dev, unsigned long current, acpi_rsdp_t *rsdp)
{
const char *oem_id = "GOOGLE";
const char *oem_table_id = "FIZZ";
diff --git a/src/mainboard/google/glados/mainboard.c b/src/mainboard/google/glados/mainboard.c
index be23f4e..8e406af 100644
--- a/src/mainboard/google/glados/mainboard.c
+++ b/src/mainboard/google/glados/mainboard.c
@@ -29,7 +29,7 @@
}
static unsigned long mainboard_write_acpi_tables(
- struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
+ struct device *dev, unsigned long current, acpi_rsdp_t *rsdp)
{
uintptr_t start_addr;
uintptr_t end_addr;
diff --git a/src/mainboard/google/lars/mainboard.c b/src/mainboard/google/lars/mainboard.c
index 43895fb..788a2ca 100644
--- a/src/mainboard/google/lars/mainboard.c
+++ b/src/mainboard/google/lars/mainboard.c
@@ -29,7 +29,7 @@
}
static unsigned long mainboard_write_acpi_tables(
- struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
+ struct device *dev, unsigned long current, acpi_rsdp_t *rsdp)
{
uintptr_t start_addr;
uintptr_t end_addr;
diff --git a/src/mainboard/google/octopus/mainboard.c b/src/mainboard/google/octopus/mainboard.c
index fc533af..5ce7fe6 100644
--- a/src/mainboard/google/octopus/mainboard.c
+++ b/src/mainboard/google/octopus/mainboard.c
@@ -42,7 +42,7 @@
}
static unsigned long mainboard_write_acpi_tables(
- struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
+ struct device *dev, unsigned long current, acpi_rsdp_t *rsdp)
{
uintptr_t start_addr;
uintptr_t end_addr;
diff --git a/src/mainboard/google/poppy/mainboard.c b/src/mainboard/google/poppy/mainboard.c
index b3e91e8..e964261 100644
--- a/src/mainboard/google/poppy/mainboard.c
+++ b/src/mainboard/google/poppy/mainboard.c
@@ -26,7 +26,7 @@
mainboard_ec_init();
}
-static unsigned long mainboard_write_acpi_tables(struct device *device,
+static unsigned long mainboard_write_acpi_tables(struct device *dev,
unsigned long current, acpi_rsdp_t *rsdp)
{
uintptr_t start_addr;
diff --git a/src/mainboard/google/reef/mainboard.c b/src/mainboard/google/reef/mainboard.c
index 6db9ac6..2111291 100644
--- a/src/mainboard/google/reef/mainboard.c
+++ b/src/mainboard/google/reef/mainboard.c
@@ -108,7 +108,7 @@
}
static unsigned long mainboard_write_acpi_tables(
- struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
+ struct device *dev, unsigned long current, acpi_rsdp_t *rsdp)
{
uintptr_t start_addr;
uintptr_t end_addr;
diff --git a/src/mainboard/google/zoombini/mainboard.c b/src/mainboard/google/zoombini/mainboard.c
index 96e1ac0..e0e88b1 100644
--- a/src/mainboard/google/zoombini/mainboard.c
+++ b/src/mainboard/google/zoombini/mainboard.c
@@ -25,7 +25,7 @@
mainboard_ec_init();
}
-static unsigned long mainboard_write_acpi_tables(struct device *device,
+static unsigned long mainboard_write_acpi_tables(struct device *dev,
unsigned long current, acpi_rsdp_t *rsdp)
{
uintptr_t start_addr;
diff --git a/src/mainboard/intel/kunimitsu/mainboard.c b/src/mainboard/intel/kunimitsu/mainboard.c
index c87b565..560c023 100644
--- a/src/mainboard/intel/kunimitsu/mainboard.c
+++ b/src/mainboard/intel/kunimitsu/mainboard.c
@@ -42,7 +42,7 @@
}
static unsigned long mainboard_write_acpi_tables(
- struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
+ struct device *dev, unsigned long current, acpi_rsdp_t *rsdp)
{
uintptr_t start_addr;
uintptr_t end_addr;
diff --git a/src/mainboard/iwill/dk8_htx/acpi_tables.c b/src/mainboard/iwill/dk8_htx/acpi_tables.c
index 957be79..91f34de 100644
--- a/src/mainboard/iwill/dk8_htx/acpi_tables.c
+++ b/src/mainboard/iwill/dk8_htx/acpi_tables.c
@@ -123,7 +123,7 @@
return current;
}
-unsigned long mainboard_write_acpi_tables(struct device *device,
+unsigned long mainboard_write_acpi_tables(struct device *dev,
unsigned long start,
acpi_rsdp_t *rsdp)
{
diff --git a/src/mainboard/iwill/dk8_htx/mainboard.h b/src/mainboard/iwill/dk8_htx/mainboard.h
index 111b445..a8bf622 100644
--- a/src/mainboard/iwill/dk8_htx/mainboard.h
+++ b/src/mainboard/iwill/dk8_htx/mainboard.h
@@ -1 +1 @@
-unsigned long mainboard_write_acpi_tables(struct device *device, unsigned long start, acpi_rsdp_t *rsdp);
+unsigned long mainboard_write_acpi_tables(struct device *dev, unsigned long start, acpi_rsdp_t *rsdp);
diff --git a/src/mainboard/lenovo/x200/mainboard.c b/src/mainboard/lenovo/x200/mainboard.c
index 1510ab7..6541635 100644
--- a/src/mainboard/lenovo/x200/mainboard.c
+++ b/src/mainboard/lenovo/x200/mainboard.c
@@ -17,7 +17,7 @@
#include <drivers/intel/gma/int15.h>
#include <drivers/lenovo/lenovo.h>
-static void fill_ssdt(struct device *device)
+static void fill_ssdt(struct device *dev)
{
drivers_lenovo_serial_ports_ssdt_generate("\\_SB.PCI0.LPCB", 0);
}
diff --git a/src/mainboard/lenovo/x201/mainboard.c b/src/mainboard/lenovo/x201/mainboard.c
index 59add68..a5912ac 100644
--- a/src/mainboard/lenovo/x201/mainboard.c
+++ b/src/mainboard/lenovo/x201/mainboard.c
@@ -73,7 +73,7 @@
printk(BIOS_SPEW, "SPI configured\n");
}
-static void fill_ssdt(struct device *device)
+static void fill_ssdt(struct device *dev)
{
drivers_lenovo_serial_ports_ssdt_generate("\\_SB.PCI0.LPCB", 0);
}
diff --git a/src/mainboard/lenovo/x60/mainboard.c b/src/mainboard/lenovo/x60/mainboard.c
index 925779e..33f0cf8 100644
--- a/src/mainboard/lenovo/x60/mainboard.c
+++ b/src/mainboard/lenovo/x60/mainboard.c
@@ -115,7 +115,7 @@
}
}
-static void fill_ssdt(struct device *device)
+static void fill_ssdt(struct device *dev)
{
drivers_lenovo_serial_ports_ssdt_generate("\\_SB.PCI0.LPCB", 1);
}
diff --git a/src/mainboard/siemens/sitemp_g1p1/acpi_tables.c b/src/mainboard/siemens/sitemp_g1p1/acpi_tables.c
index 0ced54b..8ef19c7 100644
--- a/src/mainboard/siemens/sitemp_g1p1/acpi_tables.c
+++ b/src/mainboard/siemens/sitemp_g1p1/acpi_tables.c
@@ -86,7 +86,7 @@
return current;
}
-void mainboard_inject_dsdt(struct device *device)
+void mainboard_inject_dsdt(struct device *dev)
{
global_vars_t *gnvs = cbmem_add (CBMEM_ID_ACPI_GNVS, GLOBAL_VARS_SIZE);
--
To view, visit https://review.coreboot.org/26443
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11ca08a4e4947633c03f5382467dec54fd632780
Gerrit-Change-Number: 26443
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180521/019d9ab9/attachment-0001.html>
More information about the coreboot-gerrit
mailing list