[coreboot-gerrit] Change in coreboot[master]: nb/via/cx700: Get rid of device_t

Elyes HAOUAS (Code Review) gerrit at coreboot.org
Sun May 20 10:57:27 CEST 2018


Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26424


Change subject: nb/via/cx700: Get rid of device_t
......................................................................

nb/via/cx700: Get rid of device_t

Use of device_t has been abandoned in ramstage.

Change-Id: Iaca908cc9ba5d11468a97d2f43911db925b93f1e
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/northbridge/via/cx700/agp.c
M src/northbridge/via/cx700/lpc.c
M src/northbridge/via/cx700/northbridge.c
M src/northbridge/via/cx700/vga.c
4 files changed, 12 insertions(+), 12 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/26424/1

diff --git a/src/northbridge/via/cx700/agp.c b/src/northbridge/via/cx700/agp.c
index 927fa21..d4f599e 100644
--- a/src/northbridge/via/cx700/agp.c
+++ b/src/northbridge/via/cx700/agp.c
@@ -21,10 +21,10 @@
 
 /* This is the AGP 3.0 "bridge" @ Bus 0 Device 1 Func 0 */
 
-static void agp_bridge_init(device_t dev)
+static void agp_bridge_init(struct device *dev)
 {
 
-	device_t north_dev;
+	struct device *north_dev;
 	u8 reg8;
 	north_dev = dev_find_device(PCI_VENDOR_ID_VIA, 0x3324, 0);
 
diff --git a/src/northbridge/via/cx700/lpc.c b/src/northbridge/via/cx700/lpc.c
index 4915066..6a3c80c 100644
--- a/src/northbridge/via/cx700/lpc.c
+++ b/src/northbridge/via/cx700/lpc.c
@@ -76,7 +76,7 @@
  * can't figure out how to do !!!!
  */
 
-static void setup_pm(device_t dev)
+static void setup_pm(struct device *dev)
 {
 	/* Debounce LID and PWRBTN# Inputs for 16ms. */
 	pci_write_config8(dev, 0x80, 0x20);
@@ -226,7 +226,7 @@
 
 }
 
-static void cx700_read_resources(device_t dev)
+static void cx700_read_resources(struct device *dev)
 {
 	struct resource *res;
 
@@ -248,7 +248,7 @@
 	res->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
 }
 
-static void cx700_set_resources(device_t dev)
+static void cx700_set_resources(struct device *dev)
 {
 	struct resource *resource;
 	resource = find_resource(dev, 1);
@@ -256,7 +256,7 @@
 	pci_dev_set_resources(dev);
 }
 
-static void cx700_enable_resources(device_t dev)
+static void cx700_enable_resources(struct device *dev)
 {
 	/* Enable SuperIO decoding */
 	pci_dev_enable_resources(dev);
diff --git a/src/northbridge/via/cx700/northbridge.c b/src/northbridge/via/cx700/northbridge.c
index 51e7861..ef88785 100644
--- a/src/northbridge/via/cx700/northbridge.c
+++ b/src/northbridge/via/cx700/northbridge.c
@@ -27,9 +27,9 @@
 #include <cbmem.h>
 #include <arch/acpi.h>
 
-static void pci_domain_set_resources(device_t dev)
+static void pci_domain_set_resources(struct device *dev)
 {
-	device_t mc_dev;
+	struct device *mc_dev;
 	u32 pci_tolm;
 	unsigned char reg;
 	unsigned long tomk, tolmk;
@@ -78,7 +78,7 @@
 
 unsigned long acpi_fill_mcfg(unsigned long current)
 {
-	device_t dev;
+	struct device *dev;
 	u64 mmcfg;
 
 	dev = dev_find_device(0x1106, 0x324b, 0);	// 0:0x13.0
@@ -107,7 +107,7 @@
 	.write_acpi_tables = acpi_write_hpet,
 };
 
-static void cpu_bus_init(device_t dev)
+static void cpu_bus_init(struct device *dev)
 {
 	initialize_cpus(dev->link_list);
 }
diff --git a/src/northbridge/via/cx700/vga.c b/src/northbridge/via/cx700/vga.c
index 093477a..ee9c34b 100644
--- a/src/northbridge/via/cx700/vga.c
+++ b/src/northbridge/via/cx700/vga.c
@@ -127,7 +127,7 @@
 #ifdef UNUSED_CODE
 static void write_protect_vgabios(void)
 {
-	device_t dev;
+	struct device *dev;
 
 	printk(BIOS_DEBUG, "write_protect_vgabios\n");
 
@@ -154,7 +154,7 @@
 #endif
 }
 
-static void vga_init(device_t dev)
+static void vga_init(struct device *dev)
 {
 	u8 reg8;
 

-- 
To view, visit https://review.coreboot.org/26424
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaca908cc9ba5d11468a97d2f43911db925b93f1e
Gerrit-Change-Number: 26424
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180520/1ee85e3a/attachment-0001.html>


More information about the coreboot-gerrit mailing list