[coreboot-gerrit] Change in coreboot[master]: sb/amd/cs5536: Get rid of device_t

Elyes HAOUAS (Code Review) gerrit at coreboot.org
Sat May 19 16:58:17 CEST 2018


Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26415


Change subject: sb/amd/cs5536: Get rid of device_t
......................................................................

sb/amd/cs5536: Get rid of device_t

Use of device_t has been abandoned in ramstage.

Change-Id: I995981fbaaf8c22889920a81faae631b3fd3b2ef
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/southbridge/amd/cs5536/cs5536.c
M src/southbridge/amd/cs5536/pirq.c
2 files changed, 7 insertions(+), 7 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/26415/1

diff --git a/src/southbridge/amd/cs5536/cs5536.c b/src/southbridge/amd/cs5536/cs5536.c
index 345752e..5f20c12 100644
--- a/src/southbridge/amd/cs5536/cs5536.c
+++ b/src/southbridge/amd/cs5536/cs5536.c
@@ -260,7 +260,7 @@
 	msr_t msr;
 	u16 addr = 0;
 	u32 gpio_addr;
-	device_t dev;
+	struct device *dev;
 
 	dev = dev_find_device(PCI_VENDOR_ID_AMD,
 			PCI_DEVICE_ID_AMD_CS5536_ISA, 0);
@@ -427,7 +427,7 @@
 {
 	void *bar;
 	msr_t msr;
-	device_t dev;
+	struct device *dev;
 
 	dev = dev_find_device(PCI_VENDOR_ID_AMD,
 			PCI_DEVICE_ID_AMD_CS5536_EHCI, 0);
@@ -521,7 +521,7 @@
  ****************************************************************************/
 void chipsetinit(void)
 {
-	device_t dev;
+	struct device *dev;
 	msr_t msr;
 	u32 msrnum;
 	struct southbridge_amd_cs5536_config *sb;
@@ -643,7 +643,7 @@
 	}
 }
 
-static void cs5536_read_resources(device_t dev)
+static void cs5536_read_resources(struct device *dev)
 {
 	struct resource *res;
 
@@ -667,7 +667,7 @@
 
 }
 
-static int lsmbus_read_byte(device_t dev, u8 address)
+static int lsmbus_read_byte(struct device *dev, u8 address)
 {
 	u16 device;
 	struct resource *res;
@@ -684,7 +684,7 @@
 	.read_byte  = lsmbus_read_byte,
 };
 
-static void scan_lpc_smbus(device_t dev)
+static void scan_lpc_smbus(struct device *dev)
 {
 	/* FIXME. Do we have mixed LPC/SMBus device node here. */
 	scan_smbus(dev);
diff --git a/src/southbridge/amd/cs5536/pirq.c b/src/southbridge/amd/cs5536/pirq.c
index 466a2dc..447d285 100644
--- a/src/southbridge/amd/cs5536/pirq.c
+++ b/src/southbridge/amd/cs5536/pirq.c
@@ -22,7 +22,7 @@
 #if IS_ENABLED(CONFIG_PIRQ_ROUTE) && IS_ENABLED(CONFIG_GENERATE_PIRQ_TABLE)
 void pirq_assign_irqs(const unsigned char pIntAtoD[4])
 {
-	device_t pdev;
+	struct device *pdev;
 
 	pdev = dev_find_device(PCI_VENDOR_ID_AMD,
 			       PCI_DEVICE_ID_AMD_CS5536_ISA, 0);

-- 
To view, visit https://review.coreboot.org/26415
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I995981fbaaf8c22889920a81faae631b3fd3b2ef
Gerrit-Change-Number: 26415
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180519/22b6dbe1/attachment-0001.html>


More information about the coreboot-gerrit mailing list