[coreboot-gerrit] Change in coreboot[master]: sb/via/vt8237r: Get rid of device_t

Elyes HAOUAS (Code Review) gerrit at coreboot.org
Sat May 19 10:31:11 CEST 2018


Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26395


Change subject: sb/via/vt8237r: Get rid of device_t
......................................................................

sb/via/vt8237r: Get rid of device_t

Use of device_t has been abandoned in ramstage.

Change-Id: Ic4137bc4008d08e0e0d002e52c353fc29355ccb1
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/southbridge/via/vt8237r/ctrl.c
M src/southbridge/via/vt8237r/fadt.c
M src/southbridge/via/vt8237r/ide.c
M src/southbridge/via/vt8237r/lpc.c
M src/southbridge/via/vt8237r/pirq.c
M src/southbridge/via/vt8237r/sata.c
M src/southbridge/via/vt8237r/usb.c
M src/southbridge/via/vt8237r/vt8237r.c
M src/southbridge/via/vt8237r/vt8237r.h
9 files changed, 17 insertions(+), 17 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/26395/1

diff --git a/src/southbridge/via/vt8237r/ctrl.c b/src/southbridge/via/vt8237r/ctrl.c
index 7b1518c..cc42d41 100644
--- a/src/southbridge/via/vt8237r/ctrl.c
+++ b/src/southbridge/via/vt8237r/ctrl.c
@@ -26,7 +26,7 @@
 static void vt8237_cfg(struct device *dev)
 {
 	u8 regm;
-	device_t devfun3;
+	struct device *devfun3;
 
 	devfun3 = dev_find_device(PCI_VENDOR_ID_VIA,
 				  PCI_DEVICE_ID_VIA_K8T800_DRAM, 0);
@@ -107,7 +107,7 @@
 static void vt8237s_vlink_init(struct device *dev)
 {
 	u8 reg;
-	device_t devfun7;
+	struct device *devfun7;
 
 	devfun7 = dev_find_device(PCI_VENDOR_ID_VIA,
 				  PCI_DEVICE_ID_VIA_K8T800_NB_SB_CTR, 0);
@@ -182,7 +182,7 @@
 static void vt8237a_vlink_init(struct device *dev)
 {
 	u8 reg;
-	device_t devfun7;
+	struct device *devfun7;
 
 	devfun7 = dev_find_device(PCI_VENDOR_ID_VIA,
 				  PCI_DEVICE_ID_VIA_K8T800_NB_SB_CTR, 0);
@@ -276,7 +276,7 @@
 	 * VT8237R specific configuration. Other SB are done in their own
 	 * directories. TODO: Add A version.
 	 */
-	device_t devsb = dev_find_device(PCI_VENDOR_ID_VIA,
+	struct device *devsb = dev_find_device(PCI_VENDOR_ID_VIA,
 					 PCI_DEVICE_ID_VIA_VT8237S_LPC, 0);
 	if (devsb) {
 		vt8237s_vlink_init(dev);
diff --git a/src/southbridge/via/vt8237r/fadt.c b/src/southbridge/via/vt8237r/fadt.c
index afebd7d..c5cd1d6 100644
--- a/src/southbridge/via/vt8237r/fadt.c
+++ b/src/southbridge/via/vt8237r/fadt.c
@@ -28,7 +28,7 @@
 void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
 {
 	acpi_header_t *header = &(fadt->header);
-	device_t dev;
+	struct device *dev;
 	int is_vt8237s = 0;
 
 	/* Power management controller */
diff --git a/src/southbridge/via/vt8237r/ide.c b/src/southbridge/via/vt8237r/ide.c
index e500c2c..ac9a5e7 100644
--- a/src/southbridge/via/vt8237r/ide.c
+++ b/src/southbridge/via/vt8237r/ide.c
@@ -103,7 +103,7 @@
 	pci_write_config32(dev, IDE_UDMA, cablesel);
 
 #if IS_ENABLED(CONFIG_EPIA_VT8237R_INIT)
-	device_t lpc_dev;
+	struct device *lpc_dev;
 
 	/* Set PATA Output Drive Strength */
 	lpc_dev = dev_find_device(PCI_VENDOR_ID_VIA,
diff --git a/src/southbridge/via/vt8237r/lpc.c b/src/southbridge/via/vt8237r/lpc.c
index 70ac5d9..f819493 100644
--- a/src/southbridge/via/vt8237r/lpc.c
+++ b/src/southbridge/via/vt8237r/lpc.c
@@ -62,7 +62,7 @@
 static void pci_routing_fixup(struct device *dev)
 {
 #if IS_ENABLED(CONFIG_EPIA_VT8237R_INIT)
-	device_t pdev;
+	struct device *pdev;
 #endif
 
 	/* PCI PNP Interrupt Routing INTE/F - disable */
@@ -144,7 +144,7 @@
  * This avoids having to handle any System Management Interrupts (SMIs).
  */
 
-static void setup_pm(device_t dev)
+static void setup_pm(struct device *dev)
 {
 	u16 tmp;
 	struct southbridge_via_vt8237r_config *cfg;
@@ -567,7 +567,7 @@
 	cmos_init(0);
 }
 
-static void vt8237r_read_resources(device_t dev)
+static void vt8237r_read_resources(struct device *dev)
 {
 	struct resource *res;
 
@@ -639,7 +639,7 @@
 }
 
 
-static void vt8237_set_subsystem(device_t dev, unsigned vendor, unsigned device)
+static void vt8237_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
 {
 	pci_write_config16(dev, 0x70, vendor);
 	pci_write_config16(dev, 0x72, device);
diff --git a/src/southbridge/via/vt8237r/pirq.c b/src/southbridge/via/vt8237r/pirq.c
index fd55b1f..e7eacdc 100644
--- a/src/southbridge/via/vt8237r/pirq.c
+++ b/src/southbridge/via/vt8237r/pirq.c
@@ -24,7 +24,7 @@
 #if IS_ENABLED(CONFIG_PIRQ_ROUTE) && IS_ENABLED(CONFIG_GENERATE_PIRQ_TABLE)
 void pirq_assign_irqs(const unsigned char route[4])
 {
-	device_t pdev;
+	struct device *pdev;
 
 	pdev = dev_find_device(PCI_VENDOR_ID_VIA,
 				PCI_DEVICE_ID_VIA_VT8237R_LPC, 0);
diff --git a/src/southbridge/via/vt8237r/sata.c b/src/southbridge/via/vt8237r/sata.c
index 42e3e85..d0188d5 100644
--- a/src/southbridge/via/vt8237r/sata.c
+++ b/src/southbridge/via/vt8237r/sata.c
@@ -92,7 +92,7 @@
 }
 
 
-static void vt8237_set_subsystem(device_t dev, unsigned vendor, unsigned device)
+static void vt8237_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
 {
 	pci_write_config16(dev, 0xd4, vendor);
 	pci_write_config16(dev, 0xd6, device);
diff --git a/src/southbridge/via/vt8237r/usb.c b/src/southbridge/via/vt8237r/usb.c
index 057a07d..070cd62 100644
--- a/src/southbridge/via/vt8237r/usb.c
+++ b/src/southbridge/via/vt8237r/usb.c
@@ -154,7 +154,7 @@
 	return;
 }
 
-static void vt8237_set_subsystem(device_t dev, unsigned vendor, unsigned device)
+static void vt8237_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
 {
 	pci_write_config32(dev, 0x42, pci_read_config32(dev, 0x42) | 0x10);
 	pci_write_config16(dev, 0x2c, vendor);
diff --git a/src/southbridge/via/vt8237r/vt8237r.c b/src/southbridge/via/vt8237r/vt8237r.c
index e1a0e35..b88affe 100644
--- a/src/southbridge/via/vt8237r/vt8237r.c
+++ b/src/southbridge/via/vt8237r/vt8237r.c
@@ -44,7 +44,7 @@
 }
 #endif
 
-void dump_south(device_t dev)
+void dump_south(struct device *dev)
 {
 	int i, j;
 
diff --git a/src/southbridge/via/vt8237r/vt8237r.h b/src/southbridge/via/vt8237r/vt8237r.h
index d4cc771..f383736 100644
--- a/src/southbridge/via/vt8237r/vt8237r.h
+++ b/src/southbridge/via/vt8237r/vt8237r.h
@@ -144,9 +144,9 @@
 void vt8237_early_spi_init(void);
 int vt8237_early_network_init(struct vt8237_network_rom *rom);
 #else
-void writeback(device_t dev, u16 where, u8 what);
-void dump_south(device_t dev);
-u32 vt8237_ide_80pin_detect(device_t dev);
+void writeback(struct device *dev, u16 where, u8 what);
+void dump_south(struct device *dev);
+u32 vt8237_ide_80pin_detect(struct device *dev);
 #endif
 
 #endif

-- 
To view, visit https://review.coreboot.org/26395
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4137bc4008d08e0e0d002e52c353fc29355ccb1
Gerrit-Change-Number: 26395
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180519/2f4ce958/attachment-0001.html>


More information about the coreboot-gerrit mailing list