[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: clear MCA before booting to OS

[Pratikkumar V Prajapati (Code Review)]

Pratikkumar V Prajapati has uploaded this change for review. ( https://review.coreboot.org/26392


Change subject: soc/intel/skylake: clear MCA before booting to OS
......................................................................

soc/intel/skylake: clear MCA before booting to OS

mca_configure needs to be called for each core before
booting to OS, else OS would keep dumping MCEs

Change-Id: I95ca46fda7be65d74714bdb344e339922cbb6305
Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati at intel.com>
---
M src/soc/intel/skylake/finalize.c
1 file changed, 7 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/26392/1

diff --git a/src/soc/intel/skylake/finalize.c b/src/soc/intel/skylake/finalize.c
index 25b7484..99b7e3f 100644
--- a/src/soc/intel/skylake/finalize.c
+++ b/src/soc/intel/skylake/finalize.c
@@ -2,7 +2,7 @@
  * This file is part of the coreboot project.
  *
  * Copyright (C) 2014 Google Inc.
- * Copyright (C) 2015 Intel Corporation.
+ * Copyright (C) 2015-2018 Intel Corporation.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -19,8 +19,10 @@
 #include <chip.h>
 #include <console/console.h>
 #include <console/post_codes.h>
+#include <cpu/x86/mp.h>
 #include <cpu/x86/smm.h>
 #include <device/pci.h>
+#include <intelblocks/cpulib.h>
 #include <intelblocks/lpc_lib.h>
 #include <intelblocks/pcr.h>
 #include <reg_script.h>
@@ -34,6 +36,7 @@
 #include <soc/systemagent.h>
 #include <soc/thermal.h>
 #include <stdlib.h>
+#include <timer.h>
 
 #define PSF_BASE_ADDRESS	0xA00
 #define PCR_PSFX_T0_SHDW_PCIEN	0x1C
@@ -176,6 +179,9 @@
 {
 	printk(BIOS_DEBUG, "Finalizing chipset.\n");
 
+	printk(BIOS_DEBUG, "Clearing MCA.\n");
+	mp_run_on_all_cpus(mca_configure, NULL, 14 * USECS_PER_MSEC);
+
 	pch_finalize_script();
 
 	soc_lockdown();

-- 
To view, visit https://review.coreboot.org/26392
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I95ca46fda7be65d74714bdb344e339922cbb6305
Gerrit-Change-Number: 26392
Gerrit-PatchSet: 1
Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180519/8994959d/attachment.html>