[coreboot-gerrit] Change in coreboot[master]: lib/gnat: Drop Restriction `No_Exception_Propagation`

Nico Huber (Code Review) gerrit at coreboot.org
Thu May 17 16:17:57 CEST 2018


Hello Patrick Georgi, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/26350

to look at the new patch set (#2).

Change subject: lib/gnat: Drop Restriction `No_Exception_Propagation`
......................................................................

lib/gnat: Drop Restriction `No_Exception_Propagation`

It turns out that even with the `-gnatp` switch to suppress runtime
checks, the compiler is still allowed to generate them (it only doesn't
have to). If we can't control generation of checks, we also can't
make assumptions about propagation of their exceptions.

The compiler warning that led to this change seems spurious, though
(the check might be generated, but is dropped later). So we might
revert this decision if the compiler can be fixed.

Change-Id: I7470d74b1f96f90d0d15b24dfd636d5f1c778d46
Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
M src/lib/gnat/system.ads
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/26350/2
-- 
To view, visit https://review.coreboot.org/26350
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7470d74b1f96f90d0d15b24dfd636d5f1c778d46
Gerrit-Change-Number: 26350
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180517/ecd8e591/attachment.html>


More information about the coreboot-gerrit mailing list