[coreboot-gerrit] Change in coreboot[4.8_branch]: Makefile.inc: Drop spurious `-t` from `cbfstool add-payload`
Martin Roth (Code Review)
gerrit at coreboot.org
Wed May 16 20:42:05 CEST 2018
Hello Nico Huber,
I'd like you to do a code review. Please visit
https://review.coreboot.org/26332
to review the following change.
Change subject: Makefile.inc: Drop spurious `-t` from `cbfstool add-payload`
......................................................................
Makefile.inc: Drop spurious `-t` from `cbfstool add-payload`
The `-t` argument was never required for `add-payload` and results in
a warning now because the type was renamed.
TEST=Built with BUILD_TIMELESS=1 and compared binaries with and without
this patch.
Change-Id: I6ccb70acc6e88a602b90c625040d4f05d8e3630a
Signed-off-by: Nico Huber <nico.h at gmx.de>
---
M Makefile.inc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/26332/1
diff --git a/Makefile.inc b/Makefile.inc
index b11f6e2..10b7d1b 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -685,8 +685,8 @@
$(filter flat-binary,$(call extract_nth,3,$(1))),-flat-binary) \
-f $(call extract_nth,1,$(1)) \
-n $(call extract_nth,2,$(1)) \
- $(if $(filter-out flat-binary,$(filter-out stage,$(call \
- extract_nth,3,$(1)))),-t $(call extract_nth,3,$(1))) \
+ $(if $(filter-out flat-binary payload stage,$(call \
+ extract_nth,3,$(1))),-t $(call extract_nth,3,$(1))) \
$(if $(call extract_nth,4,$(1)),-c $(call extract_nth,4,$(1))) \
$(cbfs-autogen-attributes) \
-r $(2) \
--
To view, visit https://review.coreboot.org/26332
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.8_branch
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ccb70acc6e88a602b90c625040d4f05d8e3630a
Gerrit-Change-Number: 26332
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180516/90d1599f/attachment.html>
More information about the coreboot-gerrit
mailing list