[coreboot-gerrit] Change in coreboot[master]: eve: Select WIFI_SAR_CBFS and add SAR default settings to CBFS

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/26223 )

Change subject: eve: Select WIFI_SAR_CBFS and add SAR default settings to CBFS
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/26223/1/src/mainboard/google/eve/Makefile.inc
File src/mainboard/google/eve/Makefile.inc:

https://review.coreboot.org/#/c/26223/1/src/mainboard/google/eve/Makefile.inc@31
PS1, Line 31: cbfs-files-$(CONFIG_WIFI_SAR_CBFS)  += $(CONFIG_WIFI_SAR_CBFS_FILENAME)
            : $(CONFIG_WIFI_SAR_CBFS_FILENAME)-file := $(top)/src/mainboard/$(MAINBOARDDIR)/$(call strip_quotes,$(CONFIG_WIFI_SAR_CBFS_FILENAME))
            : $(CONFIG_WIFI_SAR_CBFS_FILENAME)-type := raw
Why is this not added to wifi driver Makefile?



-- 
To view, visit https://review.coreboot.org/26223
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I851478731ad5aff58a0ca098ebd7b216a56751e0
Gerrit-Change-Number: 26223
Gerrit-PatchSet: 1
Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan at google.com>
Gerrit-Comment-Date: Fri, 11 May 2018 05:56:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180511/e164301d/attachment.html>