[coreboot-gerrit] Change in coreboot[master]: drivers/intel/gma: Allocate vbt_data on heap instead of .bss

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/26215 )

Change subject: drivers/intel/gma: Allocate vbt_data on heap instead of .bss
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/26215/1/src/drivers/intel/gma/opregion.c
File src/drivers/intel/gma/opregion.c:

https://review.coreboot.org/#/c/26215/1/src/drivers/intel/gma/opregion.c@47
PS1, Line 47: if (vbt_data_used == 1)
this implementation has been done with an assumption that data will will there in BSS hence heap won;t be enough to replace this. i need to locate everytime if using heap. hence revert this patch.



-- 
To view, visit https://review.coreboot.org/26215
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac5d52847389298f48baaf497e9bf5dff18175c7
Gerrit-Change-Number: 26215
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Subrata Banik <subrata.banik at intel.com>
Gerrit-Comment-Date: Thu, 10 May 2018 13:22:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180510/03761c23/attachment.html>