[coreboot-gerrit] Change in coreboot[master]: nb/intel/i945/raminit.c: Remove not necessary braces {}

Elyes HAOUAS (Code Review) gerrit at coreboot.org
Wed May 9 19:11:20 CEST 2018


Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26201


Change subject: nb/intel/i945/raminit.c: Remove not necessary braces {}
......................................................................

nb/intel/i945/raminit.c: Remove not necessary braces {}

Braces {} are not necessary for single statement blocks.

Change-Id: I2a2d8672fe3f53450dcfa53dc127b89b4aa6b75e
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/northbridge/intel/i945/raminit.c
1 file changed, 2 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/26201/1

diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c
index b2348f5..483d5d3 100644
--- a/src/northbridge/intel/i945/raminit.c
+++ b/src/northbridge/intel/i945/raminit.c
@@ -504,14 +504,12 @@
 		}
 		dimm_mask |= (1 << i);
 	}
-	if (!dimm_mask) {
+	if (!dimm_mask)
 		die("No memory installed.\n");
-	}
 
-	if (!(dimm_mask & ((1 << DIMM_SOCKETS) - 1))) {
+	if (!(dimm_mask & ((1 << DIMM_SOCKETS) - 1)))
 		/* Possibly does not boot in this case */
 		printk(BIOS_INFO, "Channel 0 has no memory populated.\n");
-	}
 }
 
 static void choose_tclk(struct sys_info *sysinfo,

-- 
To view, visit https://review.coreboot.org/26201
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a2d8672fe3f53450dcfa53dc127b89b4aa6b75e
Gerrit-Change-Number: 26201
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180509/aa19c6ff/attachment.html>


More information about the coreboot-gerrit mailing list