[coreboot-gerrit] Change in coreboot[master]: mainboard/asus/am1i-a: fix interrupt routing definitions in DSDT

Patrick Georgi (Code Review) gerrit at coreboot.org
Wed May 9 15:17:38 CEST 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/23771 )

Change subject: mainboard/asus/am1i-a: fix interrupt routing definitions in DSDT
......................................................................

mainboard/asus/am1i-a: fix interrupt routing definitions in DSDT

Incorrect interrupt routing configuration prevented handling
interrupts for devices behind PCIe bridges 00:02.1 and 00:02.5.
With the new configuration, devices work as expected.

Tested with Linux 4.10 booted with the "pci=nomsi" parameter.

Change-Id: I3c95be7ba6207697afc7983d4b5f9d9a28584723
Signed-off-by: Gergely Kiss <mail.gery at gmail.com>
Reviewed-on: https://review.coreboot.org/23771
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
---
M src/mainboard/asus/am1i-a/acpi/routing.asl
1 file changed, 14 insertions(+), 14 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved



diff --git a/src/mainboard/asus/am1i-a/acpi/routing.asl b/src/mainboard/asus/am1i-a/acpi/routing.asl
index 76d1c47..95881fa 100644
--- a/src/mainboard/asus/am1i-a/acpi/routing.asl
+++ b/src/mainboard/asus/am1i-a/acpi/routing.asl
@@ -61,14 +61,14 @@
 
 	/* Bus 0, Dev 1, Func 0 - PCI Bridge for Internal Graphics(IGP) */
 	/* Bus 0, Dev 1, Func 1 - HDMI Audio Controller */
-	Package(){0x0001FFFF, 0, 0, 16 },
-	Package(){0x0001FFFF, 1, 0, 17 },
+	Package(){0x0001FFFF, 0, 0, 44 },
+	Package(){0x0001FFFF, 1, 0, 45 },
 
 	/* Bus 0, Dev 2 - PCIe Bridges  */
-	Package(){0x0002FFFF, 0, 0, 16 },
-	Package(){0x0002FFFF, 1, 0, 17 },
-	Package(){0x0002FFFF, 2, 0, 18 },
-	Package(){0x0002FFFF, 3, 0, 19 },
+	Package(){0x0002FFFF, 0, 0, 24 },
+	Package(){0x0002FFFF, 1, 0, 25 },
+	Package(){0x0002FFFF, 2, 0, 26 },
+	Package(){0x0002FFFF, 3, 0, 27 },
 
 	/* SB devices in APIC mode */
 	/* Bus 0, Dev 20 - F0:SMBus/ACPI,F2:HDAudio;F3:LPC;F7:SD */
@@ -102,10 +102,10 @@
 	Package(){0x0000FFFF, 3, INTD, 0 },
 })
 Name(APS4, Package(){
-	Package(){0x0000FFFF, 0, 0, 16 },
-	Package(){0x0000FFFF, 1, 0, 17 },
-	Package(){0x0000FFFF, 2, 0, 18 },
-	Package(){0x0000FFFF, 3, 0, 19 },
+	Package(){0x0000FFFF, 0, 0, 24 },
+	Package(){0x0000FFFF, 1, 0, 25 },
+	Package(){0x0000FFFF, 2, 0, 26 },
+	Package(){0x0000FFFF, 3, 0, 27 },
 })
 
 /* GPP 1 - not used */
@@ -158,8 +158,8 @@
 	Package(){0x0000FFFF, 3, INTA, 0 },
 })
 Name(APS8, Package(){
-	Package(){0x0000FFFF, 0, 0, 17 },
-	Package(){0x0000FFFF, 1, 0, 18 },
-	Package(){0x0000FFFF, 2, 0, 19 },
-	Package(){0x0000FFFF, 3, 0, 16 },
+	Package(){0x0000FFFF, 0, 0, 40 },
+	Package(){0x0000FFFF, 1, 0, 41 },
+	Package(){0x0000FFFF, 2, 0, 42 },
+	Package(){0x0000FFFF, 3, 0, 43 },
 })

-- 
To view, visit https://review.coreboot.org/23771
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c95be7ba6207697afc7983d4b5f9d9a28584723
Gerrit-Change-Number: 23771
Gerrit-PatchSet: 2
Gerrit-Owner: Gergely Kiss <mail.gery at gmail.com>
Gerrit-Reviewer: Gergely Kiss <mail.gery at gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180509/53db9b48/attachment.html>


More information about the coreboot-gerrit mailing list