[coreboot-gerrit] Change in coreboot[master]: cpu/amd/quadcore: Get rid of device_t

Patrick Georgi (Code Review) gerrit at coreboot.org
Wed May 9 15:15:56 CEST 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/26066 )

Change subject: cpu/amd/quadcore: Get rid of device_t
......................................................................

cpu/amd/quadcore: Get rid of device_t

Use of device_t has been abandoned in ramstage.

Change-Id: I6cb8f36dea4a22fdf05c57bb3e3dcaeb2da8020f
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
Reviewed-on: https://review.coreboot.org/26066
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Patrick Rudolph <siro at das-labor.org>
---
M src/cpu/amd/quadcore/amd_sibling.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Rudolph: Looks good to me, approved



diff --git a/src/cpu/amd/quadcore/amd_sibling.c b/src/cpu/amd/quadcore/amd_sibling.c
index 129e025..32b1784 100644
--- a/src/cpu/amd/quadcore/amd_sibling.c
+++ b/src/cpu/amd/quadcore/amd_sibling.c
@@ -26,7 +26,7 @@
 #include <cpu/amd/model_10xxx_rev.h>
 #include <cpu/amd/amdfam10_sysconf.h>
 
-extern device_t get_node_pci(u32 nodeid, u32 fn);
+extern struct device *get_node_pci(u32 nodeid, u32 fn);
 
 #if 0
 static int first_time = 1;
@@ -36,7 +36,7 @@
 
 static u32 get_max_siblings(u32 nodes)
 {
-	device_t dev;
+	struct device *dev;
 	u32 nodeid;
 	u32 siblings = 0;
 
@@ -55,7 +55,7 @@
 
 static void enable_apic_ext_id(u32 nodes)
 {
-	device_t dev;
+	struct device *dev;
 	u32 nodeid;
 
 	//enable APIC_EXIT_ID all the nodes

-- 
To view, visit https://review.coreboot.org/26066
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6cb8f36dea4a22fdf05c57bb3e3dcaeb2da8020f
Gerrit-Change-Number: 26066
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180509/560eb640/attachment.html>


More information about the coreboot-gerrit mailing list