[coreboot-gerrit] Change in coreboot[master]: atlas: add SPD for new samsung 4GB memory

Caveh Jalali (Code Review) gerrit at coreboot.org
Wed May 9 06:09:56 CEST 2018


Hello caveh jalali,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/26185

to review the following change.


Change subject: atlas: add SPD for new samsung 4GB memory
......................................................................

atlas: add SPD for new samsung 4GB memory

This adds a new SPD entry for samsung's new 4GB memory and updates
atlas to use it insteadof the previous gen memory.

BUG=b:79444337
TEST=booted on atlas

Change-Id: I19567736c45a1321586378c3d964c2cbebe24755
Signed-off-by: Caveh Jalali <caveh at chromium.org>
---
A src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EC-EGCG.spd.hex
M src/mainboard/google/poppy/variants/atlas/Makefile.inc
2 files changed, 17 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/26185/1

diff --git a/src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EC-EGCG.spd.hex b/src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EC-EGCG.spd.hex
new file mode 100644
index 0000000..2e4fa59
--- /dev/null
+++ b/src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EC-EGCG.spd.hex
@@ -0,0 +1,16 @@
+91 20 F1 03 05 1A 05 0A 03 11 01 08 08 00 50 15
+78 78 90 50 90 11 50 E0 90 06 3C 3C 01 90 00 00
+00 00 C2 08 00 00 00 A8 00 88 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 80 CE 01 00 00 55 00 00 00 00 00
+4B 34 45 42 45 33 30 34 45 43 2D 45 47 43 47 20
+20 20 00 00 80 CE 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
diff --git a/src/mainboard/google/poppy/variants/atlas/Makefile.inc b/src/mainboard/google/poppy/variants/atlas/Makefile.inc
index e51fdaa..7c77696 100644
--- a/src/mainboard/google/poppy/variants/atlas/Makefile.inc
+++ b/src/mainboard/google/poppy/variants/atlas/Makefile.inc
@@ -4,7 +4,7 @@
 SPD_SOURCES += hynix_dimm_H9CCNNN8GTALAR-NUD    # 0b0010
 SPD_SOURCES += samsung_dimm_K4E6E304EB-EGCF     # 0b0011
 SPD_SOURCES += hynix_dimm_H9CCNNNBJTALAR-NUD    # 0b0100
-SPD_SOURCES += samsung_dimm_K4EBE304EB-EGCG     # 0b0101
+SPD_SOURCES += samsung_dimm_K4EBE304EC-EGCG     # 0b0101
 SPD_SOURCES += hynix_dimm_H9CCNNNCLGALAR-NUD    # 0b0110
 SPD_SOURCES += micron_dimm_MT52L512M32D2PF-107  # 0b0111
 SPD_SOURCES += micron_dimm_MT52L1G32D4PG-107    # 0b1000

-- 
To view, visit https://review.coreboot.org/26185
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I19567736c45a1321586378c3d964c2cbebe24755
Gerrit-Change-Number: 26185
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: caveh jalali <caveh at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180509/e10b460e/attachment.html>


More information about the coreboot-gerrit mailing list