[coreboot-gerrit] Change in coreboot[master]: acpi: Add support for writing ACPI _PLD structures

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/26171 )

Change subject: acpi: Add support for writing ACPI _PLD structures
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/26171/1/src/arch/x86/acpi_pld.c
File src/arch/x86/acpi_pld.c:

https://review.coreboot.org/#/c/26171/1/src/arch/x86/acpi_pld.c@34
PS1, Line 34: 1
Do we want to accept this from caller?


https://review.coreboot.org/#/c/26171/1/src/arch/x86/acpi_pld.c@66
PS1, Line 66: struct
const


https://review.coreboot.org/#/c/26171/1/src/arch/x86/acpigen.c
File src/arch/x86/acpigen.c:

https://review.coreboot.org/#/c/26171/1/src/arch/x86/acpigen.c@1239
PS1, Line 1239: struct
const?


https://review.coreboot.org/#/c/26171/1/src/arch/x86/include/arch/acpi_pld.h
File src/arch/x86/include/arch/acpi_pld.h:

https://review.coreboot.org/#/c/26171/1/src/arch/x86/include/arch/acpi_pld.h@118
PS1, Line 118: struct
const



-- 
To view, visit https://review.coreboot.org/26171
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9cf1fd158eca80ead21b4725b37ab3c36b000f3
Gerrit-Change-Number: 26171
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan at google.com>
Gerrit-Comment-Date: Wed, 09 May 2018 01:50:23 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180509/1bfbf355/attachment.html>