[coreboot-gerrit] Change in coreboot[master]: acpi: Add support for generating ACPI _UPC

Furquan Shaikh (Code Review) gerrit at coreboot.org
Tue May 8 23:58:15 CEST 2018


Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/26170 )

Change subject: acpi: Add support for generating ACPI _UPC
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/26170/1/src/arch/x86/include/arch/acpi.h
File src/arch/x86/include/arch/acpi.h:

https://review.coreboot.org/#/c/26170/1/src/arch/x86/include/arch/acpi.h@657
PS1, Line 657: 0xff
Isn't this defined in ACPI spec as "Proprietary connector"?



-- 
To view, visit https://review.coreboot.org/26170
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide3768f60f96e9ad7f919ad3fb11d91045dc174a
Gerrit-Change-Number: 26170
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan at google.com>
Gerrit-Comment-Date: Tue, 08 May 2018 21:58:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180508/16867a10/attachment.html>


More information about the coreboot-gerrit mailing list