[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nocturne: update Audio configuration

[Sathyanarayana Nujella (Code Review)]

Sathyanarayana Nujella has posted comments on this change. ( https://review.coreboot.org/26143 )

Change subject: mb/google/poppy/variants/nocturne: update Audio configuration
......................................................................


Patch Set 3:

(3 comments)

https://review.coreboot.org/#/c/26143/2//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/26143/2//COMMIT_MSG@14
PS2, Line 14: 
> Is audio working after this set of changes?
No, the boards are not available yet.
Please suggest if I can put "TEST=Build Verified"


https://review.coreboot.org/#/c/26143/2/src/mainboard/google/poppy/variants/nocturne/gpio.c
File src/mainboard/google/poppy/variants/nocturne/gpio.c:

https://review.coreboot.org/#/c/26143/2/src/mainboard/google/poppy/variants/nocturne/gpio.c@263
PS2, Line 263: PAD_CFG_GPO
> This change isn't noted in the commit message
Updated commit msg to reflect it


https://review.coreboot.org/#/c/26143/2/src/mainboard/google/poppy/variants/nocturne/nhlt.c
File src/mainboard/google/poppy/variants/nocturne/nhlt.c:

https://review.coreboot.org/#/c/26143/2/src/mainboard/google/poppy/variants/nocturne/nhlt.c@24
PS2, Line 24: 4
> This is not noted in the commit description
Updated commit msg to reflect this change



-- 
To view, visit https://review.coreboot.org/26143
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e9b3a564c22de6e84e96e5e937a3aca4ae73d75
Gerrit-Change-Number: 26143
Gerrit-PatchSet: 3
Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Naveen Manohar <naveen.m at intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 08 May 2018 00:02:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180508/19db0bd5/attachment.html>