[coreboot-gerrit] Change in coreboot[master]: WIP: mb/google/poppy/variants/nocturne: update Audio configuration

[Sathyanarayana Nujella (Code Review)]

Sathyanarayana Nujella has uploaded this change for review. ( https://review.coreboot.org/26143


Change subject: WIP: mb/google/poppy/variants/nocturne: update Audio configuration
......................................................................

WIP: mb/google/poppy/variants/nocturne: update Audio configuration

Nocturne board has only Max98373 speaker amp.
Updated both NHLT and DT entries to include only Max98373
and not include DA7219.

BUG=b:79362472
TEST=None

Change-Id: I0e9b3a564c22de6e84e96e5e937a3aca4ae73d75
Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
---
M src/mainboard/google/poppy/Kconfig
M src/mainboard/google/poppy/variants/nocturne/devicetree.cb
M src/mainboard/google/poppy/variants/nocturne/gpio.c
M src/mainboard/google/poppy/variants/nocturne/nhlt.c
4 files changed, 6 insertions(+), 28 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/26143/1

diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig
index 8cd636d..2aa876b 100644
--- a/src/mainboard/google/poppy/Kconfig
+++ b/src/mainboard/google/poppy/Kconfig
@@ -81,8 +81,7 @@
 
 config INCLUDE_NHLT_BLOBS_NOCTURNE
 	bool "Include blobs for nocturne audio."
-	select NHLT_DA7219
-	select NHLT_DMIC_2CH
+	select NHLT_DMIC_4CH
 	select NHLT_MAX98373
 
 config MAINBOARD_DIR
diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
index b69273a..85392ca 100644
--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
@@ -274,23 +274,6 @@
 				register "name" = ""MAXL""
 				device i2c 32 on end
 			end
-			chip drivers/i2c/da7219
-				register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_F10_IRQ)"
-				register "btn_cfg" = "50"
-				register "mic_det_thr" = "500"
-				register "jack_ins_deb" = "20"
-				register "jack_det_rate" = ""32ms_64ms""
-				register "jack_rem_deb" = "1"
-				register "a_d_btn_thr" = "0xa"
-				register "d_b_btn_thr" = "0x16"
-				register "b_c_btn_thr" = "0x21"
-				register "c_mic_btn_thr" = "0x3e"
-				register "btn_avg" = "4"
-				register "adc_1bit_rpt" = "1"
-				register "micbias_lvl" = "2600"
-				register "mic_amp_in_sel" = ""diff""
-				device i2c 1a on end
-			end
 		end # I2C #4 - Audio
 		device pci 1c.0 on
 			chip drivers/intel/wifi
diff --git a/src/mainboard/google/poppy/variants/nocturne/gpio.c b/src/mainboard/google/poppy/variants/nocturne/gpio.c
index f69409f..b3df9ef 100644
--- a/src/mainboard/google/poppy/variants/nocturne/gpio.c
+++ b/src/mainboard/google/poppy/variants/nocturne/gpio.c
@@ -260,7 +260,7 @@
 	/* F0  : I2S2_SCLK ==> BOOT_BEEP_CLK */
 	PAD_CFG_NF_1V8(GPP_F0, NONE, DEEP, NF1),
 	/* F1  : I2S2_SFRM ==> BOOT_BEEP_BUFFER_OE */
-	PAD_CFG_NF_1V8(GPP_F1, NONE, DEEP, NF1),
+	PAD_CFG_GPO(GPP_F1, 1, DEEP),
 	/* F2  : I2S2_TXD ==> BOOT_BEEP_SFRM */
 	PAD_CFG_NC(GPP_F2),
 	/* F3  : I2S2_RXD ==> NC */
diff --git a/src/mainboard/google/poppy/variants/nocturne/nhlt.c b/src/mainboard/google/poppy/variants/nocturne/nhlt.c
index 6ff720e..04a4482 100644
--- a/src/mainboard/google/poppy/variants/nocturne/nhlt.c
+++ b/src/mainboard/google/poppy/variants/nocturne/nhlt.c
@@ -20,13 +20,9 @@
 
 void variant_nhlt_init(struct nhlt *nhlt)
 {
-	/* 2 Channel DMIC array. */
-	if (nhlt_soc_add_dmic_array(nhlt, 2))
-		printk(BIOS_ERR, "Couldn't add 2CH DMIC array.\n");
-
-	/* Dialog DA7219 Headset codec. */
-	if (nhlt_soc_add_da7219(nhlt, AUDIO_LINK_SSP1))
-		printk(BIOS_ERR, "Couldn't add Dialog DA7219 codec.\n");
+	/* 4 Channel DMIC array. */
+	if (nhlt_soc_add_dmic_array(nhlt, 4))
+		printk(BIOS_ERR, "Couldn't add 4CH DMIC array.\n");
 
 	/* MAXIM Smart Amps for left and right speakers. */
 	if (nhlt_soc_add_max98373(nhlt, AUDIO_LINK_SSP0))
@@ -37,6 +33,6 @@
 				uint32_t *oem_revision)
 {
 	*oem_id = "GOOGLE";
-	*oem_table_id = "NOCTURNEMAX";
+	*oem_table_id = "NOCTURNE";
 	*oem_revision = 0;
 }

-- 
To view, visit https://review.coreboot.org/26143
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e9b3a564c22de6e84e96e5e937a3aca4ae73d75
Gerrit-Change-Number: 26143
Gerrit-PatchSet: 1
Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180507/4948727d/attachment.html>