[coreboot-gerrit] Change in coreboot[master]: mainboard/amd/*: SIOW ACPI method doesn't use any arguments
Martin Roth (Code Review)
gerrit at coreboot.org
Mon May 7 05:51:51 CEST 2018
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/26126
Change subject: mainboard/amd/*: SIOW ACPI method doesn't use any arguments
......................................................................
mainboard/amd/*: SIOW ACPI method doesn't use any arguments
Since the SIOW method doesn't use any arguments, don't pass it any,
and initialize it as not using any.
Change-Id: I3fa2ab8afb7d09c176a94bbd1db27587c36030cd
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/amd/dbm690t/dsdt.asl
M src/mainboard/amd/mahogany/dsdt.asl
M src/mainboard/amd/mahogany_fam10/dsdt.asl
M src/mainboard/amd/tilapia_fam10/dsdt.asl
M src/mainboard/asus/m4a78-em/dsdt.asl
M src/mainboard/asus/m4a785-m/dsdt.asl
M src/mainboard/asus/m4a785t-m/dsdt.asl
M src/mainboard/biostar/am1ml/acpi/sio.asl
M src/mainboard/gigabyte/ma785gm/dsdt.asl
M src/mainboard/gigabyte/ma785gmt/dsdt.asl
M src/mainboard/gigabyte/ma78gm/dsdt.asl
M src/mainboard/iei/kino-780am2-fam10/dsdt.asl
M src/mainboard/jetway/pa78vm5/dsdt.asl
M src/mainboard/kontron/kt690/dsdt.asl
M src/mainboard/siemens/sitemp_g1p1/acpi/event.asl
M src/mainboard/siemens/sitemp_g1p1/dsdt.asl
M src/mainboard/supermicro/h8scm_fam10/dsdt.asl
M src/mainboard/technexion/tim5690/dsdt.asl
M src/mainboard/technexion/tim8690/dsdt.asl
19 files changed, 34 insertions(+), 43 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/26126/1
diff --git a/src/mainboard/amd/dbm690t/dsdt.asl b/src/mainboard/amd/dbm690t/dsdt.asl
index 78ceb01..748c9fb 100644
--- a/src/mainboard/amd/dbm690t/dsdt.asl
+++ b/src/mainboard/amd/dbm690t/dsdt.asl
@@ -886,7 +886,7 @@
* Store(Arg0, Index(WKST,1))
* }
*/
- \_SB.PCI0.SIOW (Arg0)
+ \_SB.PCI0.SIOW ()
Return(WKST)
} /* End Method(\_WAK) */
@@ -1432,7 +1432,7 @@
XPNP()
}
}
- Method (SIOW, 1)
+ Method (SIOW, 0)
{
EPNP()
Store (0x4, LDN)
diff --git a/src/mainboard/amd/mahogany/dsdt.asl b/src/mainboard/amd/mahogany/dsdt.asl
index 798f053..dfffa87 100644
--- a/src/mainboard/amd/mahogany/dsdt.asl
+++ b/src/mainboard/amd/mahogany/dsdt.asl
@@ -882,7 +882,7 @@
* Store(Arg0, Index(WKST,1))
* }
*/
- \_SB.PCI0.SIOW (Arg0)
+ \_SB.PCI0.SIOW ()
Return(WKST)
} /* End Method(\_WAK) */
@@ -1448,7 +1448,7 @@
XPNP()
}
}
- Method (SIOW, 1)
+ Method (SIOW, 0)
{
EPNP()
Store (0x4, LDN)
diff --git a/src/mainboard/amd/mahogany_fam10/dsdt.asl b/src/mainboard/amd/mahogany_fam10/dsdt.asl
index bbc3105..6c72744 100644
--- a/src/mainboard/amd/mahogany_fam10/dsdt.asl
+++ b/src/mainboard/amd/mahogany_fam10/dsdt.asl
@@ -924,7 +924,7 @@
* Store(Arg0, Index(WKST,1))
* }
*/
- \_SB.PCI0.SIOW (Arg0)
+ \_SB.PCI0.SIOW ()
Return(WKST)
} /* End Method(\_WAK) */
@@ -1491,7 +1491,7 @@
XPNP()
}
}
- Method (SIOW, 1)
+ Method (SIOW, 0)
{
EPNP()
Store (0x4, LDN)
diff --git a/src/mainboard/amd/tilapia_fam10/dsdt.asl b/src/mainboard/amd/tilapia_fam10/dsdt.asl
index 03118ee..4afab9c 100644
--- a/src/mainboard/amd/tilapia_fam10/dsdt.asl
+++ b/src/mainboard/amd/tilapia_fam10/dsdt.asl
@@ -924,7 +924,7 @@
* Store(Arg0, Index(WKST,1))
* }
*/
- \_SB.PCI0.SIOW (Arg0)
+ \_SB.PCI0.SIOW ()
Return(WKST)
} /* End Method(\_WAK) */
@@ -1490,7 +1490,7 @@
XPNP()
}
}
- Method (SIOW, 1)
+ Method (SIOW, 0)
{
EPNP()
Store (0x4, LDN)
diff --git a/src/mainboard/asus/m4a78-em/dsdt.asl b/src/mainboard/asus/m4a78-em/dsdt.asl
index 6dbfc51..be3e54d 100644
--- a/src/mainboard/asus/m4a78-em/dsdt.asl
+++ b/src/mainboard/asus/m4a78-em/dsdt.asl
@@ -924,7 +924,7 @@
* Store(Arg0, Index(WKST,1))
* }
*/
- \_SB.PCI0.SIOW (Arg0)
+ \_SB.PCI0.SIOW ()
Return(WKST)
} /* End Method(\_WAK) */
@@ -1490,7 +1490,7 @@
XPNP()
}
}
- Method (SIOW, 1)
+ Method (SIOW, 0)
{
EPNP()
Store (0x4, LDN)
diff --git a/src/mainboard/asus/m4a785-m/dsdt.asl b/src/mainboard/asus/m4a785-m/dsdt.asl
index 6dbfc51..be3e54d 100644
--- a/src/mainboard/asus/m4a785-m/dsdt.asl
+++ b/src/mainboard/asus/m4a785-m/dsdt.asl
@@ -924,7 +924,7 @@
* Store(Arg0, Index(WKST,1))
* }
*/
- \_SB.PCI0.SIOW (Arg0)
+ \_SB.PCI0.SIOW ()
Return(WKST)
} /* End Method(\_WAK) */
@@ -1490,7 +1490,7 @@
XPNP()
}
}
- Method (SIOW, 1)
+ Method (SIOW, 0)
{
EPNP()
Store (0x4, LDN)
diff --git a/src/mainboard/asus/m4a785t-m/dsdt.asl b/src/mainboard/asus/m4a785t-m/dsdt.asl
index f2222b3..8e42026 100644
--- a/src/mainboard/asus/m4a785t-m/dsdt.asl
+++ b/src/mainboard/asus/m4a785t-m/dsdt.asl
@@ -924,7 +924,7 @@
* Store(Arg0, Index(WKST,1))
* }
*/
- \_SB.PCI0.SIOW (Arg0)
+ \_SB.PCI0.SIOW ()
Return(WKST)
} /* End Method(\_WAK) */
@@ -1475,7 +1475,7 @@
XPNP()
}
}
- Method (SIOW, 1)
+ Method (SIOW, 0)
{
EPNP()
Store (0x4, LDN)
diff --git a/src/mainboard/biostar/am1ml/acpi/sio.asl b/src/mainboard/biostar/am1ml/acpi/sio.asl
index b423af5..7778faa 100644
--- a/src/mainboard/biostar/am1ml/acpi/sio.asl
+++ b/src/mainboard/biostar/am1ml/acpi/sio.asl
@@ -76,12 +76,3 @@
XPNP()
}
}
-Method (SIOW, 1)
-{
- EPNP()
- Store (0x4, LDN)
- Store (Zero, APC0) /* disable keyboard PME */
- Store (0x4, LDN)
- Store (0xFF, APC1) /* clear keyboard PME status */
- XPNP()
-}
diff --git a/src/mainboard/gigabyte/ma785gm/dsdt.asl b/src/mainboard/gigabyte/ma785gm/dsdt.asl
index 030ddb9..700e4ae 100644
--- a/src/mainboard/gigabyte/ma785gm/dsdt.asl
+++ b/src/mainboard/gigabyte/ma785gm/dsdt.asl
@@ -924,7 +924,7 @@
* Store(Arg0, Index(WKST,1))
* }
*/
- \_SB.PCI0.SIOW (Arg0)
+ \_SB.PCI0.SIOW ()
Return(WKST)
} /* End Method(\_WAK) */
@@ -1490,7 +1490,7 @@
XPNP()
}
}
- Method (SIOW, 1)
+ Method (SIOW, 0)
{
EPNP()
Store (0x4, LDN)
diff --git a/src/mainboard/gigabyte/ma785gmt/dsdt.asl b/src/mainboard/gigabyte/ma785gmt/dsdt.asl
index 030ddb9..700e4ae 100644
--- a/src/mainboard/gigabyte/ma785gmt/dsdt.asl
+++ b/src/mainboard/gigabyte/ma785gmt/dsdt.asl
@@ -924,7 +924,7 @@
* Store(Arg0, Index(WKST,1))
* }
*/
- \_SB.PCI0.SIOW (Arg0)
+ \_SB.PCI0.SIOW ()
Return(WKST)
} /* End Method(\_WAK) */
@@ -1490,7 +1490,7 @@
XPNP()
}
}
- Method (SIOW, 1)
+ Method (SIOW, 0)
{
EPNP()
Store (0x4, LDN)
diff --git a/src/mainboard/gigabyte/ma78gm/dsdt.asl b/src/mainboard/gigabyte/ma78gm/dsdt.asl
index 030ddb9..700e4ae 100644
--- a/src/mainboard/gigabyte/ma78gm/dsdt.asl
+++ b/src/mainboard/gigabyte/ma78gm/dsdt.asl
@@ -924,7 +924,7 @@
* Store(Arg0, Index(WKST,1))
* }
*/
- \_SB.PCI0.SIOW (Arg0)
+ \_SB.PCI0.SIOW ()
Return(WKST)
} /* End Method(\_WAK) */
@@ -1490,7 +1490,7 @@
XPNP()
}
}
- Method (SIOW, 1)
+ Method (SIOW, 0)
{
EPNP()
Store (0x4, LDN)
diff --git a/src/mainboard/iei/kino-780am2-fam10/dsdt.asl b/src/mainboard/iei/kino-780am2-fam10/dsdt.asl
index 9935d94..13f4fa0 100644
--- a/src/mainboard/iei/kino-780am2-fam10/dsdt.asl
+++ b/src/mainboard/iei/kino-780am2-fam10/dsdt.asl
@@ -924,7 +924,7 @@
* Store(Arg0, Index(WKST,1))
* }
*/
- \_SB.PCI0.SIOW (Arg0)
+ \_SB.PCI0.SIOW ()
Return(WKST)
} /* End Method(\_WAK) */
@@ -1491,7 +1491,7 @@
XPNP()
}
}
- Method (SIOW, 1)
+ Method (SIOW, 0)
{
EPNP()
Store (0x4, LDN)
diff --git a/src/mainboard/jetway/pa78vm5/dsdt.asl b/src/mainboard/jetway/pa78vm5/dsdt.asl
index bbd4381..0a721e9 100644
--- a/src/mainboard/jetway/pa78vm5/dsdt.asl
+++ b/src/mainboard/jetway/pa78vm5/dsdt.asl
@@ -924,7 +924,7 @@
* Store(Arg0, Index(WKST,1))
* }
*/
- \_SB.PCI0.SIOW (Arg0)
+ \_SB.PCI0.SIOW ()
Return(WKST)
} /* End Method(\_WAK) */
@@ -1490,7 +1490,7 @@
XPNP()
}
}
- Method (SIOW, 1)
+ Method (SIOW, 0)
{
EPNP()
Store (0x4, LDN)
diff --git a/src/mainboard/kontron/kt690/dsdt.asl b/src/mainboard/kontron/kt690/dsdt.asl
index 982f105..889293f 100644
--- a/src/mainboard/kontron/kt690/dsdt.asl
+++ b/src/mainboard/kontron/kt690/dsdt.asl
@@ -887,7 +887,7 @@
* Store(Arg0, Index(WKST,1))
* }
*/
- \_SB.PCI0.SIOW (Arg0)
+ \_SB.PCI0.SIOW ()
Return(WKST)
} /* End Method(\_WAK) */
@@ -1433,7 +1433,7 @@
XPNP()
}
}
- Method (SIOW, 1)
+ Method (SIOW, 0)
{
EPNP()
Store (0x4, LDN)
diff --git a/src/mainboard/siemens/sitemp_g1p1/acpi/event.asl b/src/mainboard/siemens/sitemp_g1p1/acpi/event.asl
index 89fbafb..fafb0ac 100644
--- a/src/mainboard/siemens/sitemp_g1p1/acpi/event.asl
+++ b/src/mainboard/siemens/sitemp_g1p1/acpi/event.asl
@@ -140,7 +140,7 @@
* Store(Arg0, Index(WKST,1))
* }
*/
- \_SB.PCI0.SIOW (Arg0)
+ \_SB.PCI0.SIOW ()
Return(WKST)
} /* End Method(\_WAK) */
diff --git a/src/mainboard/siemens/sitemp_g1p1/dsdt.asl b/src/mainboard/siemens/sitemp_g1p1/dsdt.asl
index 7a5fc85..121aaf9 100644
--- a/src/mainboard/siemens/sitemp_g1p1/dsdt.asl
+++ b/src/mainboard/siemens/sitemp_g1p1/dsdt.asl
@@ -1132,7 +1132,7 @@
XPNP()
}
}
- Method (SIOW, 1)
+ Method (SIOW, 0)
{
EPNP()
Store (0x4, LDN)
diff --git a/src/mainboard/supermicro/h8scm_fam10/dsdt.asl b/src/mainboard/supermicro/h8scm_fam10/dsdt.asl
index bfb9a7a..1599767 100644
--- a/src/mainboard/supermicro/h8scm_fam10/dsdt.asl
+++ b/src/mainboard/supermicro/h8scm_fam10/dsdt.asl
@@ -942,7 +942,7 @@
* Store(Arg0, Index(WKST,1))
* }
*/
- \_SB.PCI0.SIOW (Arg0)
+ \_SB.PCI0.SIOW ()
Return(WKST)
} /* End Method(\_WAK) */
@@ -1526,7 +1526,7 @@
XPNP()
}
}
- Method (SIOW, 1)
+ Method (SIOW, 0)
{
EPNP()
Store (0x4, LDN)
diff --git a/src/mainboard/technexion/tim5690/dsdt.asl b/src/mainboard/technexion/tim5690/dsdt.asl
index 223c7ca..44da647 100644
--- a/src/mainboard/technexion/tim5690/dsdt.asl
+++ b/src/mainboard/technexion/tim5690/dsdt.asl
@@ -886,7 +886,7 @@
* Store(Arg0, Index(WKST,1))
* }
*/
- \_SB.PCI0.SIOW (Arg0)
+ \_SB.PCI0.SIOW ()
Return(WKST)
} /* End Method(\_WAK) */
@@ -1432,7 +1432,7 @@
XPNP()
}
}
- Method (SIOW, 1)
+ Method (SIOW, 0)
{
EPNP()
Store (0x4, LDN)
diff --git a/src/mainboard/technexion/tim8690/dsdt.asl b/src/mainboard/technexion/tim8690/dsdt.asl
index 6786797..ae82a2a 100644
--- a/src/mainboard/technexion/tim8690/dsdt.asl
+++ b/src/mainboard/technexion/tim8690/dsdt.asl
@@ -886,7 +886,7 @@
* Store(Arg0, Index(WKST,1))
* }
*/
- \_SB.PCI0.SIOW (Arg0)
+ \_SB.PCI0.SIOW ()
Return(WKST)
} /* End Method(\_WAK) */
@@ -1432,7 +1432,7 @@
XPNP()
}
}
- Method (SIOW, 1)
+ Method (SIOW, 0)
{
EPNP()
Store (0x4, LDN)
--
To view, visit https://review.coreboot.org/26126
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3fa2ab8afb7d09c176a94bbd1db27587c36030cd
Gerrit-Change-Number: 26126
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180507/b1dc1cbd/attachment-0001.html>
More information about the coreboot-gerrit
mailing list