[coreboot-gerrit] Change in coreboot[master]: intel/acpi: Fix ACPI compile error

Martin Roth (Code Review) gerrit at coreboot.org
Sat May 5 17:02:02 CEST 2018


Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/26045 )

Change subject: intel/acpi: Fix ACPI compile error
......................................................................

intel/acpi: Fix ACPI compile error

According to ACPI 6.1 spec 19.6.44, External informs compiler that
object is external to this TABLE, no necessary for object in same DSDT
tables.

BUG=None
TEST=Build pass Intel mainboard with 20180427 iasl.

Change-Id: I153e7d0e97f9a29919676fbb73a7c26fd22f252c
Signed-off-by: Lijian Zhao <lijian.zhao at intel.com>
Reviewed-on: https://review.coreboot.org/26045
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Martin Roth <martinroth at google.com>
---
M src/soc/intel/braswell/acpi/dptf/cpu.asl
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved



diff --git a/src/soc/intel/braswell/acpi/dptf/cpu.asl b/src/soc/intel/braswell/acpi/dptf/cpu.asl
index fafd438..9625cac 100644
--- a/src/soc/intel/braswell/acpi/dptf/cpu.asl
+++ b/src/soc/intel/braswell/acpi/dptf/cpu.asl
@@ -47,7 +47,6 @@
 External (\_PR.CP00._PTC, PkgObj)
 External (\_PR.CP00._TSD, PkgObj)
 External (\_PR.CP00._PSS, MethodObj)
-External (\_SB.DPTF.CTOK, MethodObj)
 
 Device (B0DB)
 {

-- 
To view, visit https://review.coreboot.org/26045
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I153e7d0e97f9a29919676fbb73a7c26fd22f252c
Gerrit-Change-Number: 26045
Gerrit-PatchSet: 8
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180505/b99ffcdc/attachment.html>


More information about the coreboot-gerrit mailing list